bugfix(keycloak): fix parameters for realm key creation #8823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
felixfontein
reviewed
Sep 2, 2024
| @@ -371,7 +371,7 @@ def main(): | |||
| parent_id = module.params.get('parent_id') | |||
|
|
|||
| # Get a list of all Keycloak components that are of keyprovider type. | |||
| realm_keys = kc.get_components(urlencode(dict(type=provider_type, parent=parent_id)), parent_id) | |||
| realm_keys = kc.get_components(urlencode(dict(type=provider_type)), parent_id) | |||
There was a problem hiding this comment.
Hmm, I wonder whether this is something that changed over time, and thus is still needed for older Keycloak versions.
There was a problem hiding this comment.
a) looking at the oldest available docs (keycloak 21.0), this has always been optional
b) it is filtered to this realm scope anyways since .get_components requests from GET /{realm}/components
Co-authored-by: Felix Fontein <[email protected]>
|
If nobody objects I'll merge this on this weekend for 9.4.0. |
felixfontein
removed
the
check-before-release
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8839 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
* bugfix(keycloak): fix parameters for realm key creation * supply changelog fragment * fix formatting * fix formatting * Update changelogs/fragments/8823-keycloak-realm-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea389e7)
|
@fivetide thanks for your contribution! |
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8840 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
* bugfix(keycloak): fix parameters for realm key creation * supply changelog fragment * fix formatting * fix formatting * Update changelogs/fragments/8823-keycloak-realm-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea389e7)
felixfontein
pushed a commit
that referenced
this pull request
Sep 8, 2024
…rs for realm key creation (#8840) bugfix(keycloak): fix parameters for realm key creation (#8823) * bugfix(keycloak): fix parameters for realm key creation * supply changelog fragment * fix formatting * fix formatting * Update changelogs/fragments/8823-keycloak-realm-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea389e7) Co-authored-by: Björn Bösel <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Sep 8, 2024
…rs for realm key creation (#8839) bugfix(keycloak): fix parameters for realm key creation (#8823) * bugfix(keycloak): fix parameters for realm key creation * supply changelog fragment * fix formatting * fix formatting * Update changelogs/fragments/8823-keycloak-realm-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ea389e7) Co-authored-by: Björn Bösel <[email protected]>
aioue
pushed a commit
to aioue/community.general
that referenced
this pull request
Oct 1, 2024
…ections#8823) * bugfix(keycloak): fix parameters for realm key creation * supply changelog fragment * fix formatting * fix formatting * Update changelogs/fragments/8823-keycloak-realm-key.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes #7850. Realm key creation on keycloak side needs the parent_id to be either the ID of the realm or to be omitted. The modules mixed up the realm name - as used in the url - with the id, leading to invalid created entities. In addition the get_components request for getting the current state filtered with the same invalid value.
ISSUE TYPE
COMPONENT NAME
community.general.keycloak_realm_key