Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MH deco: minor refactor #8766

Merged
merged 6 commits into from
Aug 17, 2024

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Aug 15, 2024

SUMMARY

Minor improvements in the decorators

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/module_utils/mh/deco.py

@ansibullbot ansibullbot added module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) labels Aug 15, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Aug 15, 2024
@russoz russoz changed the title MH deco: minor refactor [WIP] MH deco: minor refactor Aug 15, 2024
@ansibullbot ansibullbot added the WIP Work in progress label Aug 15, 2024
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added tests tests unit tests/unit labels Aug 15, 2024
@russoz russoz changed the title [WIP] MH deco: minor refactor MH deco: minor refactor Aug 17, 2024
@ansibullbot ansibullbot removed WIP Work in progress needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 17, 2024
@felixfontein felixfontein merged commit c84fb55 into ansible-collections:main Aug 17, 2024
147 checks passed
Copy link

patchback bot commented Aug 17, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/c84fb5577b6f39a0c8c03e43daaf143d359bbbcd/pr-8766

Backported as #8775

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 17, 2024
patchback bot pushed a commit that referenced this pull request Aug 17, 2024
* MH deco: minor refactor

* adjustments and improvement in test

* sanity fix

* use func.__self__

* simplify use of self

* add changelog frag

(cherry picked from commit c84fb55)
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Aug 17, 2024
MH deco: minor refactor (#8766)

* MH deco: minor refactor

* adjustments and improvement in test

* sanity fix

* use func.__self__

* simplify use of self

* add changelog frag

(cherry picked from commit c84fb55)

Co-authored-by: Alexei Znamensky <[email protected]>
@russoz russoz deleted the mh-deco-improve branch August 17, 2024 20:07
fgruenbauer pushed a commit to fgruenbauer/community.general that referenced this pull request Aug 20, 2024
* MH deco: minor refactor

* adjustments and improvement in test

* sanity fix

* use func.__self__

* simplify use of self

* add changelog frag
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
* MH deco: minor refactor

* adjustments and improvement in test

* sanity fix

* use func.__self__

* simplify use of self

* add changelog frag
TobiasZeuch181 pushed a commit to TobiasZeuch181/zypper_repository_add_list that referenced this pull request Oct 2, 2024
* MH deco: minor refactor

* adjustments and improvement in test

* sanity fix

* use func.__self__

* simplify use of self

* add changelog frag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch module_utils module_utils plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants