[PR #8708/76d0222a backport][stable-8] homebrew_cask: fix upgrade_all changed when nothing upgraded #8748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* homebrew_cask: fix upgrade_all changed when nothing upgraded * Add changelog fragment * Update changelogs/fragments/8708-homebrew_cask-fix-upgrade-all.yml Co-authored-by: Felix Fontein <[email protected]> * Add .strip() to upgrade output check Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: John Byrne <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 76d0222)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-8/76d0222a83d7986e8fa6f693e87218cd0931f835/pr-8708
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8708 as merged into main (76d0222).
SUMMARY
Fixes bug with homebrew_cask upgrade_all where the module always returns 'changed' due to change in output behavior of the
brewcommand.Fixes #8707
ISSUE TYPE
COMPONENT NAME
homebrew_cask