Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace the passwordstore lockfile #8689

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Namespace the passwordstore lockfile #8689

merged 5 commits into from
Aug 12, 2024

Conversation

m0zes
Copy link
Contributor

@m0zes m0zes commented Jul 29, 2024

SUMMARY

When passwordstore needs to grab a lock, it creates a statically named file (within /tmp, typically). It also leaves that lock file around after it is done with it. This is unfortunate as there might be more than one user using the passwordstore functionality on a single machine, even if they aren't using it contemporaneously. Prepend the username to the filename so that the lock file is unique per user.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

passwordstore

ADDITIONAL INFORMATION
  1. run a playbook that will lookup from a passwordstore
  2. login as another user
  3. run the same or another playbook that will lookup from a passwordstore
  4. it errors out because the lockfile exists and cannot be removed (due to not being the owner of the file)

@m0zes
Namespace the lockfile
bf42553 
When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.
@m0zes m0zes changed the title Namespace the lockfile Namespace the passwordstore lockfile Jul 29, 2024
@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jul 29, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Jul 29, 2024
felixfontein
felixfontein reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

plugins/lookup/passwordstore.py Outdated Show resolved Hide resolved
m0zes and others added 3 commits July 29, 2024 12:37
@m0zes @felixfontein
Update plugins/lookup/passwordstore.py
3449585 
specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>
@m0zes
Add changelog fragment for PR#8689
676e30c
@m0zes
Update 8689-passwordstore-lock-naming.yml
fa43962 
I was sure that was a copy/paste.
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 29, 2024
@m0zes @felixfontein
Update changelogs/fragments/8689-passwordstore-lock-naming.yml
d9a7873 
specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this on Monday.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 9, 2024
@felixfontein felixfontein merged commit 8989b6c into ansible-collections:main Aug 12, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Aug 12, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/8989b6c4d4b7588c7f0c97185fb18bb9bf9d08c2/pr-8689

Backported as #8745

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 12, 2024
patchback bot pushed a commit that referenced this pull request Aug 12, 2024
@m0zes @patchback
Namespace the passwordstore lockfile (#8689)
9fded5a 
* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 8989b6c)
@patchback patchback bot mentioned this pull request Aug 12, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Aug 12, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/8989b6c4d4b7588c7f0c97185fb18bb9bf9d08c2/pr-8689

Backported as #8746

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 12, 2024
@m0zes @patchback
Namespace the passwordstore lockfile (#8689)
79a70b1 
* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 8989b6c)
@patchback patchback bot mentioned this pull request Aug 12, 2024
Merged
@felixfontein
Copy link
Collaborator

@m0zes thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Aug 12, 2024
@patchback @m0zes
[PR #8689/8989b6c4 backport][stable-8] Namespace the passwordstore lo…
f9ad730 
…ckfile (#8745)

Namespace the passwordstore lockfile (#8689)

* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 8989b6c)

Co-authored-by: Adam Tygart <[email protected]>
felixfontein pushed a commit that referenced this pull request Aug 12, 2024
@patchback @m0zes
[PR #8689/8989b6c4 backport][stable-9] Namespace the passwordstore lo…
176f6a6 
…ckfile (#8746)

Namespace the passwordstore lockfile (#8689)

* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 8989b6c)

Co-authored-by: Adam Tygart <[email protected]>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@m0zes @felixfontein @aioue
Namespace the passwordstore lockfile (ansible-collections#8689)
37e005b 
* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
TobiasZeuch181 pushed a commit to TobiasZeuch181/zypper_repository_add_list that referenced this pull request Oct 2, 2024
@m0zes @felixfontein @TobiasZeuch181
Namespace the passwordstore lockfile (ansible-collections#8689)
12247e5 
* Namespace the lockfile

When passwordstore needs to grab a lock, it creates a statically file (within /tmp, typically). This is unfortunate, when there might be more than one user using the passwordstore functionality on that machine. Prepend the user to the filename, to bypass further issues.

* Update plugins/lookup/passwordstore.py

specifically reference the argument number in the format string.

Co-authored-by: Felix Fontein <[email protected]>

* Add changelog fragment for PR#8689

* Update 8689-passwordstore-lock-naming.yml

I was sure that was a copy/paste.

* Update changelogs/fragments/8689-passwordstore-lock-naming.yml

specify the type of plugin

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug lookup lookup plugin new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0zes @felixfontein @ansibullbot