-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redfish_utils: fix language check #8613
redfish_utils: fix language check #8613
Conversation
Looks good to me, thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Thanks for the quick review! |
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8616 🤖 @patchback |
* redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]> (cherry picked from commit ca8ecb1)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8617 🤖 @patchback |
@mkoreneff thanks for your contribution! |
* redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]> (cherry picked from commit ca8ecb1)
…eck (#8616) redfish_utils: fix language check (#8613) * redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]> (cherry picked from commit ca8ecb1) Co-authored-by: Mike Koreneff <[email protected]>
…eck (#8617) redfish_utils: fix language check (#8613) * redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]> (cherry picked from commit ca8ecb1) Co-authored-by: Mike Koreneff <[email protected]>
* redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]>
* redfish_utils: fix language check * add fragment file * typo * improve words * improve words based on suggestion --------- Co-authored-by: Mike Koreneff <[email protected]>
SUMMARY
Fixes bug when Language is not exactly
en
incorrectly returns
example:
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/redfish_utils.py
ADDITIONAL INFORMATION
Reproduce the issue:
bios_registry.yaml:
ansible-playbook --inventory "host," bios_registry.yaml
with the fix in place
ansible-playbook --inventory "host," bios_registry.yaml