Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd_runner - handle special value "auto" in param force_lang #8517

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jun 16, 2024

SUMMARY

Supplying the special value auto to the force_lang parameter now has the effect of determining the locale to be used in the command execution by calling ansible.module_utils.common.locale.get_best_parsable_locale().

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/cmd_runner.py

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) labels Jun 16, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Jun 16, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 25, 2024
@ansibullbot
Copy link
Collaborator

cc @emonty
click here for bot help

@ansibullbot ansibullbot added module module and removed stale_ci CI is older than 7 days, rerun before merging labels Jun 27, 2024
@felixfontein felixfontein merged commit 5259caa into ansible-collections:main Jul 5, 2024
150 checks passed
Copy link

patchback bot commented Jul 5, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/5259caacae58204b7140a373a11dcb5ac5f2365e/pr-8517

Backported as #8581

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 5, 2024
patchback bot pushed a commit that referenced this pull request Jul 5, 2024
* cmd_runner - handle special value "auto" in param force_lang

* add changelog frag

* update doc in puppet

* fix markup

(cherry picked from commit 5259caa)
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jul 5, 2024
…lue "auto" in param force_lang (#8581)

cmd_runner - handle special value "auto" in param force_lang (#8517)

* cmd_runner - handle special value "auto" in param force_lang

* add changelog frag

* update doc in puppet

* fix markup

(cherry picked from commit 5259caa)

Co-authored-by: Alexei Znamensky <[email protected]>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
…-collections#8517)

* cmd_runner - handle special value "auto" in param force_lang

* add changelog frag

* update doc in puppet

* fix markup
@russoz russoz deleted the cmd-runner-lang-auto branch November 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request module_utils module_utils module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants