Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to handle Redfish Gen2 Firmware upgrade #8444

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fix to handle Redfish Gen2 Firmware upgrade #8444

merged 5 commits into from
Jul 8, 2024

Conversation

cmadarsh
Copy link
Contributor

SUMMARY

Fix to enable firmware upgrade on our Gen2 redfish based UltraStar Data102 platform.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wdc_redfish_command module

ADDITIONAL INFORMATION

Firmware upgrade in case of Gen2 UltraStar Data102 platform is handled with the new firmware bundle format.

@ansibullbot
Copy link
Collaborator

cc @mikemoerk
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) labels May 31, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label May 31, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Jun 1, 2024
@felixfontein
Copy link
Collaborator

Thanks for your contribution! Please check the failing sanity tests, and add a changelog fragment. Thanks.

@ansibullbot ansibullbot added tests tests unit tests/unit and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 4, 2024
@cmadarsh
Copy link
Contributor Author

cmadarsh commented Jun 5, 2024

Ready for review

felixfontein
felixfontein reviewed Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the documentation of the wdc_redfish_command module also be updated to mention this somehow?

changelogs/fragments/8444-fix-redfish-gen2-upgrade.yaml Outdated Show resolved Hide resolved
@cmadarsh
Copy link
Contributor Author

Should the documentation of the wdc_redfish_command module also be updated to mention this somehow?

By default wdc_redfish_command module should work irrespective of the Redfish platform versions. I feel it need not be documented.

@cmadarsh
Copy link
Contributor Author

Ready for review

@cmadarsh
Copy link
Contributor Author

Ready for Review

@felixfontein
Copy link
Collaborator

I cannot judge the actual change. If nobody objects, I'll merge this in 1-2 weeks.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 27, 2024
@cmadarsh
Copy link
Contributor Author

I cannot judge the actual change. If nobody objects, I'll merge this in 1-2 weeks.

Ok, please merge, the changes are specific to Western Digital platform and its modules, which has been tested.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 8, 2024
@felixfontein felixfontein merged commit feb1ecb into ansible-collections:main Jul 8, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Jul 8, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/feb1ecbfcddcc417bbae672674e080d3f6d1894d/pr-8444

Backported as #8600

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@cmadarsh thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Jul 8, 2024
@cmadarsh @patchback
Fix to handle Redfish Gen2 Firmware upgrade (#8444)
5a25a7b 
* Fix to handle Redfish Gen2 Firmware upgrade

* Fixed sanity checks and unit test cases

* Added change log gragment

* Updated change log fragment

* Updated review comments

---------

Co-authored-by: Adarsh Manjunath <[email protected]>
(cherry picked from commit feb1ecb)
@patchback patchback bot mentioned this pull request Jul 8, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Jul 8, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/feb1ecbfcddcc417bbae672674e080d3f6d1894d/pr-8444

Backported as #8601

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 8, 2024
@cmadarsh @patchback
Fix to handle Redfish Gen2 Firmware upgrade (#8444)
9708def 
* Fix to handle Redfish Gen2 Firmware upgrade

* Fixed sanity checks and unit test cases

* Added change log gragment

* Updated change log fragment

* Updated review comments

---------

Co-authored-by: Adarsh Manjunath <[email protected]>
(cherry picked from commit feb1ecb)
@patchback patchback bot mentioned this pull request Jul 8, 2024
Merged
felixfontein pushed a commit that referenced this pull request Jul 8, 2024
@patchback @cmadarsh
[PR #8444/feb1ecbf backport][stable-9] Fix to handle Redfish Gen2 Fir…
b0af1e9 
…mware upgrade (#8601)

Fix to handle Redfish Gen2 Firmware upgrade (#8444)

* Fix to handle Redfish Gen2 Firmware upgrade

* Fixed sanity checks and unit test cases

* Added change log gragment

* Updated change log fragment

* Updated review comments

---------

Co-authored-by: Adarsh Manjunath <[email protected]>
(cherry picked from commit feb1ecb)

Co-authored-by: cmadarsh <[email protected]>
felixfontein pushed a commit that referenced this pull request Jul 8, 2024
@patchback @cmadarsh
[PR #8444/feb1ecbf backport][stable-8] Fix to handle Redfish Gen2 Fir…
261d2f9 
…mware upgrade (#8600)

Fix to handle Redfish Gen2 Firmware upgrade (#8444)

* Fix to handle Redfish Gen2 Firmware upgrade

* Fixed sanity checks and unit test cases

* Added change log gragment

* Updated change log fragment

* Updated review comments

---------

Co-authored-by: Adarsh Manjunath <[email protected]>
(cherry picked from commit feb1ecb)

Co-authored-by: cmadarsh <[email protected]>
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@cmadarsh @aioue
Fix to handle Redfish Gen2 Firmware upgrade (ansible-collections#8444)
4d4f723 
* Fix to handle Redfish Gen2 Firmware upgrade

* Fixed sanity checks and unit test cases

* Added change log gragment

* Updated change log fragment

* Updated review comments

---------

Co-authored-by: Adarsh Manjunath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch bug This issue/PR relates to a bug module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmadarsh @ansibullbot @felixfontein