#8440 Allow for API Port to be specified when using proxmox_kvm #8441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
WIP
felixfontein
added
check-before-release
Will work on that and submit again :) |
- Added documentation on api_port - Fixed multiple spaces after operator - Switched from str to int
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
reviewed
Jun 1, 2024
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
|
If nobody objects, I'll merge this in ~a week. |
1 task
felixfontein
removed
the
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8478 🤖 @patchback |
|
@tgouverneur thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 8, 2024
* added api_port * added changelog fragments for #8440 * api_port minor changes - Added documentation on api_port - Fixed multiple spaces after operator - Switched from str to int * Update changelogs/fragments/8440-allow-api-port-specification.yaml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/8440-allow-api-port-specification.yaml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/doc_fragments/proxmox.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/doc_fragments/proxmox.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit d2d7deb)
felixfontein
pushed a commit
that referenced
this pull request
Jun 8, 2024
… specified when using proxmox_kvm (#8478) #8440 Allow for API Port to be specified when using proxmox_kvm (#8441) * added api_port * added changelog fragments for #8440 * api_port minor changes - Added documentation on api_port - Fixed multiple spaces after operator - Switched from str to int * Update changelogs/fragments/8440-allow-api-port-specification.yaml Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/8440-allow-api-port-specification.yaml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/doc_fragments/proxmox.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/doc_fragments/proxmox.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit d2d7deb) Co-authored-by: Thomas Gouverneur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implements #8440
ISSUE TYPE
COMPONENT NAME
modules_utils/proxmox.py
ADDITIONAL INFORMATION
N/A -- see #8440