Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycloak set client authentification flows by name #8428

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Keycloak set client authentification flows by name #8428

merged 11 commits into from
Jun 17, 2024

Conversation

desand01
Copy link
Contributor

SUMMARY

Allow the assignment of authentication flows by name

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

keycloak_client.py

@ansibullbot
Copy link
Collaborator

cc @eikef @mattock @ndclt
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels May 27, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 27, 2024
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label May 27, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label May 27, 2024
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 27, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels May 27, 2024
@desand01
Copy link
Contributor Author

desand01 commented Jun 4, 2024

Should "Keycloak.get_authentication_flow_by_alias" be case insensitive?

felixfontein
felixfontein reviewed Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other two suboptions were available before, and these two not, let's mark them as new :)

plugins/modules/keycloak_client.py Show resolved Hide resolved
plugins/modules/keycloak_client.py Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

Should "Keycloak.get_authentication_flow_by_alias" be case insensitive?

I have no idea, I would hope that someone else with Keycloak experience can weight in here :) I would probably expect users to use the same casing, but 🤷

@desand01
Copy link
Contributor Author

desand01 commented Jun 8, 2024 •
edited
Loading

Should "Keycloak.get_authentication_flow_by_alias" be case insensitive?

I have no idea, I would hope that someone else with Keycloak experience can weight in here :) I would probably expect users to use the same casing, but 🤷

You are probably right. Let leave it like it is

@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this tomorrow!

russoz
russoz approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 16, 2024
@felixfontein felixfontein merged commit b11da28 into ansible-collections:main Jun 17, 2024
132 checks passed
@patchback Patchback
Copy link

patchback bot commented Jun 17, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/b11da288d2b49cb0a5a371fc33dec49a76ad8fbf/pr-8428

Backported as #8524

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 17, 2024
patchback bot pushed a commit that referenced this pull request Jun 17, 2024
@desand01 @patchback
Keycloak set client authentification flows by name (#8428)
cd19b54 
* first commit

* Add change logs

* fix sanity

* Sanity 2

* Test unset flows

* Update plugins/modules/keycloak_client.py

Co-authored-by: Alexei Znamensky <[email protected]>

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

* Update changelogs/fragments/8428-assign-auth-flow-by-name-keycloak-client.yaml

Co-authored-by: Felix Fontein <[email protected]>

* Remove double traitement from "alias"

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Andre Desrosiers <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit b11da28)
@patchback patchback bot mentioned this pull request Jun 17, 2024
Merged
@felixfontein
Copy link
Collaborator

@desand01 thanks for your contribution!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Jun 17, 2024
@patchback @desand01
[PR #8428/b11da288 backport][stable-9] Keycloak set client authentifi…
f96c647 
…cation flows by name (#8524)

Keycloak set client authentification flows by name (#8428)

* first commit

* Add change logs

* fix sanity

* Sanity 2

* Test unset flows

* Update plugins/modules/keycloak_client.py

Co-authored-by: Alexei Znamensky <[email protected]>

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

* Update changelogs/fragments/8428-assign-auth-flow-by-name-keycloak-client.yaml

Co-authored-by: Felix Fontein <[email protected]>

* Remove double traitement from "alias"

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Andre Desrosiers <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit b11da28)

Co-authored-by: desand01 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desand01 @ansibullbot @felixfontein @russoz