multiple modules: use new vardict in module #8411

russoz · 2024-05-24T00:38:37Z

SUMMARY

Add

    use_old_vardict = False

to the module.

Fixes #8410

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

locale_gen

ansibullbot · 2024-05-24T00:42:10Z

cc @AugustusKling
click here for bot help

changelogs/fragments/8411-locale-gen-vardict.yml

felixfontein · 2024-05-24T04:35:31Z

Are there potentially more modules in c.g with the same deprecation?

russoz · 2024-05-24T05:13:19Z

There are others:

plugins/modules/ansible_galaxy_install.py:178:class AnsibleGalaxyInstall(ModuleHelper):
plugins/modules/cpanm.py:145:class CPANMinus(ModuleHelper):
plugins/modules/django_command.py:64:class DjangoCommand(DjangoModuleHelper):
plugins/modules/gconftool2_info.py:55:class GConftoolInfo(ModuleHelper):
plugins/modules/gio_mime.py:78:class GioMime(ModuleHelper):
plugins/modules/hponcfg.py:87:class HPOnCfg(ModuleHelper):
plugins/modules/jira.py:472:class JIRA(StateModuleHelper):
plugins/modules/kernel_blacklist.py:60:class Blacklist(StateModuleHelper):
plugins/modules/mksysb.py:112:class MkSysB(ModuleHelper):
plugins/modules/pipx_info.py:141:class PipXInfo(ModuleHelper):
plugins/modules/snap_alias.py:93:class SnapAlias(StateModuleHelper):
plugins/modules/snap.py:178:class Snap(StateModuleHelper):

^ filtered out the ones that are already using the new VarDict

felixfontein · 2024-05-24T19:59:32Z

Do you want to fix them here, or in a separate PR?

felixfontein · 2024-05-24T20:00:39Z

(Would be great to get at least some of these in until Monday, so I can create a bugfix release for Ansible 10.0.0rc1.)

russoz · 2024-05-24T20:28:37Z

Well, I wasn't planning on rushing with those but I suppose some of them are going to be low-hanging fruits. Will use this PR a little further.

Co-authored-by: Felix Fontein <[email protected]>

ansibullbot · 2024-05-24T23:20:44Z

cc @angristan @fcuny @vcarceler
click here for bot help

ansibullbot · 2024-05-24T23:34:43Z

cc @MorrisA @bcoca @d-little @flynn1973 @gforster @haad @kairoaraujo @marvin-sinister @mator @matze @molekuul @ramooncamacho @wtcross
click here for bot help

russoz · 2024-05-25T05:27:35Z

@felixfontein the jira and gio_mime modules will require more work, so I will leave those for separate PRs. Other than that, ready for review.

patchback · 2024-05-26T11:56:52Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/ec886203fc5d7805fe867188084664e607d503b5/pr-8411

Backported as #8419

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein · 2024-05-26T11:56:58Z

@russoz thanks!

* use new vardict in module * add changelog frag * Update changelogs/fragments/8411-locale-gen-vardict.yml Co-authored-by: Felix Fontein <[email protected]> * set use_old_vardict to false in snap * set use_old_vardict to false in cpanm * set use_old_vardict to false in django mod helper * set use_old_vardict to false in gconftool2_info * set use_old_vardict to false in kernel_blacklist * set use_old_vardict to false in mksysb * set use_old_vardict to false in pipx_info * set use_old_vardict to false in snap_alias * update chglog frag * fix typo --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ec88620)

…ict in module (#8419) multiple modules: use new vardict in module (#8411) * use new vardict in module * add changelog frag * Update changelogs/fragments/8411-locale-gen-vardict.yml Co-authored-by: Felix Fontein <[email protected]> * set use_old_vardict to false in snap * set use_old_vardict to false in cpanm * set use_old_vardict to false in django mod helper * set use_old_vardict to false in gconftool2_info * set use_old_vardict to false in kernel_blacklist * set use_old_vardict to false in mksysb * set use_old_vardict to false in pipx_info * set use_old_vardict to false in snap_alias * update chglog frag * fix typo --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit ec88620) Co-authored-by: Alexei Znamensky <[email protected]>

ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) small_patch Hopefully easy to review labels May 24, 2024

russoz changed the title ~~use new vardict in module~~ locale_gen: use new vardict in module May 24, 2024

ansibullbot removed the small_patch Hopefully easy to review label May 24, 2024

felixfontein reviewed May 24, 2024

View reviewed changes

changelogs/fragments/8411-locale-gen-vardict.yml Outdated Show resolved Hide resolved

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels May 24, 2024

russoz and others added 4 commits May 25, 2024 11:04

use new vardict in module

4447a7b

add changelog frag

910dbe9

Update changelogs/fragments/8411-locale-gen-vardict.yml

bf591ff

Co-authored-by: Felix Fontein <[email protected]>

set use_old_vardict to false in snap

72cced0

russoz force-pushed the 8410-locale-gen-vardict-warning branch from e28ff83 to 72cced0 Compare May 24, 2024 23:06

russoz added 3 commits May 25, 2024 11:09

set use_old_vardict to false in cpanm

f8ab4f9

set use_old_vardict to false in django mod helper

eac66c6

set use_old_vardict to false in gconftool2_info

118a2bc

russoz force-pushed the 8410-locale-gen-vardict-warning branch from 3250fd8 to 118a2bc Compare May 24, 2024 23:20

ansibullbot added the module_utils module_utils label May 24, 2024

russoz added 4 commits May 25, 2024 11:24

set use_old_vardict to false in kernel_blacklist

9966037

set use_old_vardict to false in mksysb

c0b99ec

set use_old_vardict to false in pipx_info

53cad01

set use_old_vardict to false in snap_alias

604d539

russoz changed the title ~~locale_gen: use new vardict in module~~ multiple modules: use new vardict in module May 24, 2024

russoz added 2 commits May 25, 2024 11:46

update chglog frag

014727f

fix typo

27e031c

felixfontein approved these changes May 25, 2024

View reviewed changes

felixfontein merged commit ec88620 into ansible-collections:main May 26, 2024
132 checks passed

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 26, 2024

patchback bot mentioned this pull request May 26, 2024

[PR #8411/ec886203 backport][stable-9] multiple modules: use new vardict in module #8419

Merged

russoz deleted the 8410-locale-gen-vardict-warning branch May 26, 2024 18:32

felixfontein mentioned this pull request May 30, 2024

locale_gen uses deprecated VarDict from ModuleHelper #8433

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multiple modules: use new vardict in module #8411

multiple modules: use new vardict in module #8411

russoz commented May 24, 2024 •

edited

Loading

ansibullbot commented May 24, 2024

felixfontein commented May 24, 2024

russoz commented May 24, 2024 •

edited

Loading

felixfontein commented May 24, 2024

felixfontein commented May 24, 2024

russoz commented May 24, 2024

ansibullbot commented May 24, 2024

ansibullbot commented May 24, 2024

russoz commented May 25, 2024 •

edited

Loading

patchback bot commented May 26, 2024 •

edited

Loading

felixfontein commented May 26, 2024

multiple modules: use new vardict in module #8411

multiple modules: use new vardict in module #8411

Conversation

russoz commented May 24, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibullbot commented May 24, 2024

felixfontein commented May 24, 2024

russoz commented May 24, 2024 • edited Loading

felixfontein commented May 24, 2024

felixfontein commented May 24, 2024

russoz commented May 24, 2024

ansibullbot commented May 24, 2024

ansibullbot commented May 24, 2024

russoz commented May 25, 2024 • edited Loading

patchback bot commented May 26, 2024 • edited Loading

Backport to stable-9: 💚 backport PR created

felixfontein commented May 26, 2024

russoz commented May 24, 2024 •

edited

Loading

russoz commented May 24, 2024 •

edited

Loading

russoz commented May 25, 2024 •

edited

Loading

patchback bot commented May 26, 2024 •

edited

Loading