-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry][callback] Add support for http exporter #8321
[opentelemetry][callback] Add support for http exporter #8321
Conversation
b53a1da
to
71e8670
Compare
Ping @mihai-satmarean this should fix your error. |
The previous version of the callback was supporting only the grpc exporter. This was counter intuitive as the documentation was mentioning `<your endpoint (OTLP/HTTP)>`. Users were left with a error similar to `Transient error StatusCode.UNAVAILABLE encountered while exporting traces to <endpoint>, retrying in 1s.` The following commit fix this situation by support both HTTP and GRPC via the standard environment variables and ansible.cfg See as well ansible-collections#7888 Signed-off-by: Wilfried Roset <[email protected]>
71e8670
to
9f18813
Compare
Hi, thank you! I will find some time these days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some comments below.
Thanks @wilfriedroset , that's super great. I'll run some manual tests to validate your changes on my end this week (likely by the end of the week) |
Thank for the quick review @felixfontein, I've taken into account all your comments. |
1640983
to
8e8dd8e
Compare
Signed-off-by: Wilfried Roset <[email protected]>
8e8dd8e
to
7868223
Compare
LGTM (although I am not familiar with the callback nor I use OT at the moment) |
@v1v did you have a chance to look at this? |
I've been working on setting a test environment and it took me longer. I'm gonna run some tests shortly, thanks for your patient 🙏 |
All good, I did run a few manual executions. Thanks so much @wilfriedroset |
6889e04
into
ansible-collections:main
@wilfriedroset thanks a lot for your contribution! |
…t-flag * upstream/main: Add REUSE badge (ansible-collections#8365) Initial commit for django modutils and django_command module (ansible-collections#8349) [opentelemetry][callback] Add support for http exporter (ansible-collections#8321) Fix sanitize for keycloak_identitiy_provider. (ansible-collections#8355)
…ections#8321) * [opentelemetry][callback] Add support for http exporter The previous version of the callback was supporting only the grpc exporter. This was counter intuitive as the documentation was mentioning `<your endpoint (OTLP/HTTP)>`. Users were left with a error similar to `Transient error StatusCode.UNAVAILABLE encountered while exporting traces to <endpoint>, retrying in 1s.` The following commit fix this situation by support both HTTP and GRPC via the standard environment variables and ansible.cfg See as well ansible-collections#7888 Signed-off-by: Wilfried Roset <[email protected]> * [opentelemetry][callback] Take into account review Signed-off-by: Wilfried Roset <[email protected]> --------- Signed-off-by: Wilfried Roset <[email protected]>
SUMMARY
The previous version of the callback was supporting only the grpc exporter. This was counter intuitive as the documentation was mentioning
<your endpoint (OTLP/HTTP)>
. Users were left with a error similar toTransient error StatusCode.UNAVAILABLE encountered while exporting traces to <endpoint>, retrying in 1s.
The following commit fix this situation by support both HTTP and GRPC via the standard environment variables and ansible.cfg
Fixes #7888
ISSUE TYPE
COMPONENT NAME
community.general.opentelemetry
ADDITIONAL INFORMATION
To reproduce and validate the correct behavior
Consider the following directory setup
Set
ansible.cfg
Set a sample playbook:
The execution environment is the following, please note that any environment with ansible and the correct python deps should work as well
Here is the docker-compose file
Build the image
Start the stack
Now enter the execution environment
Witness ansible complaining about the error before the patch
After the file is patched and the correct variable is exported there is no error the trace is visible in the backend