Fix keycloak sanitize_cr #5934
Merged
Fix keycloak sanitize_cr #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
felixfontein
reviewed
Feb 3, 2023
There was a problem hiding this comment.
Thanks for your contribution. Please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
claudusd
force-pushed
the
keycloak/fix_sanitize
branch
from
be1832b
to
b8e6cca
Compare
ansibullbot
added
ci_verified
claudusd
force-pushed
the
keycloak/fix_sanitize
branch
from
b8e6cca
to
5dd0558
Compare
ansibullbot
removed
ci_verified
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Feb 22, 2023
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #6035 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Fix keycloak sanitize_cr * Update changelogs/fragments/5934-fix-keycloak-sanitize_cr.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Claude Dioudonnat <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 78297e4)
|
@claudusd thanks for fixing this! |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6036 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Fix keycloak sanitize_cr * Update changelogs/fragments/5934-fix-keycloak-sanitize_cr.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Claude Dioudonnat <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 78297e4)
felixfontein
pushed a commit
that referenced
this pull request
Feb 22, 2023
Fix keycloak sanitize_cr (#5934) * Fix keycloak sanitize_cr * Update changelogs/fragments/5934-fix-keycloak-sanitize_cr.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Claude Dioudonnat <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 78297e4) Co-authored-by: Claude Dioudonnat <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Feb 22, 2023
Fix keycloak sanitize_cr (#5934) * Fix keycloak sanitize_cr * Update changelogs/fragments/5934-fix-keycloak-sanitize_cr.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Claude Dioudonnat <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 78297e4) Co-authored-by: Claude Dioudonnat <[email protected]>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
jikamens
pushed a commit
to jikamens/community.general
that referenced
this pull request
Feb 25, 2023
* Fix keycloak sanitize_cr * Update changelogs/fragments/5934-fix-keycloak-sanitize_cr.yml Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Claude Dioudonnat <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When we want to set the private saml key with the module
keycloak_clientkeycloak receive the value no_logThe function
sanitize_crset the no_log value to avoid print the key value in the ansible log.But the function copy of dict only copy the first level and keep the reference for sub dict.
ISSUE TYPE
COMPONENT NAME
keycloak_client