Clearer error logging in passwordstore lookup

[jplitza]

(re-creation of ansible/ansible#47120)

SUMMARY

There are many reasons why password store would return exit code 1. Just search for "exit 1" in https://git.zx2c4.com/password-store/tree/src/password-store.sh. This change creates clearer error messages, so one can see what is actually wrong.

Fixes #3759

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lookup passwordstore

ADDITIONAL INFORMATION

before:

fatal: [testhost-01]: FAILED! => {
    "changed": false,
    "msg": "AnsibleError: An unhandled exception occurred while templating '{{ test_pass }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ lookup(\"passwordstore\", \"{{ test_passwordstore_path }}/test create={{ not ansible_check_mode }}\") }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while running the lookup plugin 'passwordstore'. Error was a <class 'ansible.errors.AnsibleError'>, original message: command ['pass', 'insert', '-f', '-m', u'testpath/test']. returned non-zero exit status 1"
}

after:

fatal: [testhost-01]: FAILED! => {
    "changed": false,
    "msg": "AnsibleError: An unhandled exception occurred while templating '{{ test_pass }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while templating '{{ lookup(\"passwordstore\", \"{{ test_passwordstore_path }}/test create={{ not ansible_check_mode }}\") }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while running the lookup plugin 'passwordstore'. Error was a <class 'ansible.errors.AnsibleError'>, original message: exit code 1 while running ['pass', 'insert', '-f', '-m', u'testpath/test']. Error output: Enter contents of testpath/test and press Ctrl+D when finished:\n\ngpg: ABCDEF0123456789: There is no assurance this key belongs to the named user\ngpg: [stdin]: encryption failed: Unusable public key\nPassword encryption aborted.\n"
}

[felixfontein]

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

[felixfontein]

Looks good to me. If nobody complains, I'm going to merge this in ~a week.

[patchback]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/e4b9e098c74e405cae911d01d2561e208ff3421c/pr-5436

Backported as #5458

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@jplitza thanks for your contribution!

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.