Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scaleway] Add module to manage container namespaces #5416

Conversation

Lunik
Copy link
Contributor

@Lunik Lunik commented Oct 23, 2022

SUMMARY

This PR add new modules to manage Scaleway container namespaces services (https://developers.scaleway.com/).

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • scaleway_container_namespace
  • scaleway_container_namespace_info
ADDITIONAL INFORMATION

This PR is a part of the original PR #5359 that was too large.

This PR require evolution on Scaleway config in ansible-test : ansible/ansible#79141

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added cloud integration tests/integration module module new_plugin New plugin plugins plugin (any type) tests tests labels Oct 23, 2022
@github-actions
Copy link

github-actions bot commented Oct 23, 2022

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/community.general/actions/runs/3381083186

File changes:

  • A collections/community/general/scaleway_container_namespace_info_module.html
  • A collections/community/general/scaleway_container_namespace_module.html
  • M collections/community/general/index.html
  • M collections/community/general/scaleway_compute_private_network_module.html
  • M collections/community/general/scaleway_container_registry_module.html
  • M collections/index_module.html
Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/index.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/index.html
index 555d575..cd1e1dc 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/index.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/index.html
@@ -617,6 +617,8 @@
 <li><p><a class="reference internal" href="say_module.html#ansible-collections-community-general-say-module"><span class="std std-ref">say module</span></a> – Makes a computer to speak.</p></li>
 <li><p><a class="reference internal" href="scaleway_compute_module.html#ansible-collections-community-general-scaleway-compute-module"><span class="std std-ref">scaleway_compute module</span></a> – Scaleway compute management module</p></li>
 <li><p><a class="reference internal" href="scaleway_compute_private_network_module.html#ansible-collections-community-general-scaleway-compute-private-network-module"><span class="std std-ref">scaleway_compute_private_network module</span></a> – Scaleway compute - private network management</p></li>
+<li><p><a class="reference internal" href="scaleway_container_namespace_module.html#ansible-collections-community-general-scaleway-container-namespace-module"><span class="std std-ref">scaleway_container_namespace module</span></a> – Scaleway Container namespace management</p></li>
+<li><p><a class="reference internal" href="scaleway_container_namespace_info_module.html#ansible-collections-community-general-scaleway-container-namespace-info-module"><span class="std std-ref">scaleway_container_namespace_info module</span></a> – Retrieve information on Scaleway Container namespace</p></li>
 <li><p><a class="reference internal" href="scaleway_container_registry_module.html#ansible-collections-community-general-scaleway-container-registry-module"><span class="std std-ref">scaleway_container_registry module</span></a> – Scaleway Container registry management module</p></li>
 <li><p><a class="reference internal" href="scaleway_container_registry_info_module.html#ansible-collections-community-general-scaleway-container-registry-info-module"><span class="std std-ref">scaleway_container_registry_info module</span></a> – Scaleway Container registry info module</p></li>
 <li><p><a class="reference internal" href="scaleway_database_backup_module.html#ansible-collections-community-general-scaleway-database-backup-module"><span class="std std-ref">scaleway_database_backup module</span></a> – Scaleway database backups management module</p></li>
diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/scaleway_compute_private_network_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/scaleway_compute_private_network_module.html
index 655e0a3..1f402b3 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/scaleway_compute_private_network_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/scaleway_compute_private_network_module.html
@@ -22,7 +22,7 @@
         <script src="../../../_static/sphinx_highlight.js"></script>
     <script src="../../../_static/js/theme.js"></script>
     <link rel="search" title="Search" href="../../../search.html" />
-    <link rel="next" title="community.general.scaleway_container_registry module – Scaleway Container registry management module" href="scaleway_container_registry_module.html" />
+    <link rel="next" title="community.general.scaleway_container_namespace module – Scaleway Container namespace management" href="scaleway_container_namespace_module.html" />
     <link rel="prev" title="community.general.scaleway_compute module – Scaleway compute management module" href="scaleway_compute_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
@@ -344,7 +344,7 @@
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
         <a href="scaleway_compute_module.html" class="btn btn-neutral float-left" title="community.general.scaleway_compute module – Scaleway compute management module" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
-        <a href="scaleway_container_registry_module.html" class="btn btn-neutral float-right" title="community.general.scaleway_container_registry module – Scaleway Container registry management module" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+        <a href="scaleway_container_namespace_module.html" class="btn btn-neutral float-right" title="community.general.scaleway_container_namespace module – Scaleway Container namespace management" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
   <hr/>
diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/scaleway_container_registry_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/scaleway_container_registry_module.html
index b8268f3..13426d4 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/scaleway_container_registry_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/scaleway_container_registry_module.html
@@ -23,7 +23,7 @@
     <script src="../../../_static/js/theme.js"></script>
     <link rel="search" title="Search" href="../../../search.html" />
     <link rel="next" title="community.general.scaleway_container_registry_info module – Scaleway Container registry info module" href="scaleway_container_registry_info_module.html" />
-    <link rel="prev" title="community.general.scaleway_compute_private_network module – Scaleway compute - private network management" href="scaleway_compute_private_network_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+    <link rel="prev" title="community.general.scaleway_container_namespace_info module – Retrieve information on Scaleway Container namespace" href="scaleway_container_namespace_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
 
@@ -378,7 +378,7 @@
           
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
-        <a href="scaleway_compute_private_network_module.html" class="btn btn-neutral float-left" title="community.general.scaleway_compute_private_network module – Scaleway compute - private network management" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+        <a href="scaleway_container_namespace_info_module.html" class="btn btn-neutral float-left" title="community.general.scaleway_container_namespace_info module – Retrieve information on Scaleway Container namespace" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
         <a href="scaleway_container_registry_info_module.html" class="btn btn-neutral float-right" title="community.general.scaleway_container_registry_info module – Scaleway Container registry info module" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/index_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/index_module.html
index 064fc2a..b774743 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/index_module.html
@@ -557,6 +557,8 @@
 <li><p><a class="reference internal" href="community/general/say_module.html#ansible-collections-community-general-say-module"><span class="std std-ref">community.general.say</span></a> – Makes a computer to speak.</p></li>
 <li><p><a class="reference internal" href="community/general/scaleway_compute_module.html#ansible-collections-community-general-scaleway-compute-module"><span class="std std-ref">community.general.scaleway_compute</span></a> – Scaleway compute management module</p></li>
 <li><p><a class="reference internal" href="community/general/scaleway_compute_private_network_module.html#ansible-collections-community-general-scaleway-compute-private-network-module"><span class="std std-ref">community.general.scaleway_compute_private_network</span></a> – Scaleway compute - private network management</p></li>
+<li><p><a class="reference internal" href="community/general/scaleway_container_namespace_module.html#ansible-collections-community-general-scaleway-container-namespace-module"><span class="std std-ref">community.general.scaleway_container_namespace</span></a> – Scaleway Container namespace management</p></li>
+<li><p><a class="reference internal" href="community/general/scaleway_container_namespace_info_module.html#ansible-collections-community-general-scaleway-container-namespace-info-module"><span class="std std-ref">community.general.scaleway_container_namespace_info</span></a> – Retrieve information on Scaleway Container namespace</p></li>
 <li><p><a class="reference internal" href="community/general/scaleway_container_registry_module.html#ansible-collections-community-general-scaleway-container-registry-module"><span class="std std-ref">community.general.scaleway_container_registry</span></a> – Scaleway Container registry management module</p></li>
 <li><p><a class="reference internal" href="community/general/scaleway_container_registry_info_module.html#ansible-collections-community-general-scaleway-container-registry-info-module"><span class="std std-ref">community.general.scaleway_container_registry_info</span></a> – Scaleway Container registry info module</p></li>
 <li><p><a class="reference internal" href="community/general/scaleway_database_backup_module.html#ansible-collections-community-general-scaleway-database-backup-module"><span class="std std-ref">community.general.scaleway_database_backup</span></a> – Scaleway database backups management module</p></li>

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Oct 23, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Oct 23, 2022
@Lunik Lunik changed the title [Scaleway] Add module to manage container namespaces WIP: [Scaleway] Add module to manage container namespaces Oct 24, 2022
@Lunik
Copy link
Contributor Author

Lunik commented Oct 24, 2022

I have put this PR in WIP during the time we try to resolve all issues on #5415

@ansibullbot ansibullbot added the WIP Work in progress label Oct 24, 2022
@Lunik Lunik force-pushed the scaleway-add-container-namespace-module branch from 5182dba to 9ed0a0a Compare October 29, 2022 09:26
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Oct 29, 2022
@Lunik Lunik force-pushed the scaleway-add-container-namespace-module branch from 9ed0a0a to 08b6ba6 Compare November 1, 2022 10:18
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 1, 2022
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Nov 1, 2022
@Lunik Lunik force-pushed the scaleway-add-container-namespace-module branch from 08b6ba6 to 5b08350 Compare November 2, 2022 19:50
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 2, 2022
@Lunik Lunik changed the title WIP: [Scaleway] Add module to manage container namespaces [Scaleway] Add module to manage container namespaces Nov 2, 2022
@Lunik
Copy link
Contributor Author

Lunik commented Nov 2, 2022

ready_for_review

CI seems to fail because of #5462

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed WIP Work in progress labels Nov 2, 2022
@Lunik Lunik force-pushed the scaleway-add-container-namespace-module branch from b0c1a37 to 7816d07 Compare November 2, 2022 20:58
@ansibullbot ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 2, 2022
@Lunik
Copy link
Contributor Author

Lunik commented Nov 4, 2022

ready_for_review

@felixfontein
Copy link
Collaborator

If nobody complains, I'll merge this weekend.

@felixfontein felixfontein merged commit 1e17ec1 into ansible-collections:main Nov 5, 2022
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 5, 2022
@felixfontein
Copy link
Collaborator

@Lunik thanks for this one as well!

russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 10, 2022
…ions#5416)

* [Scaleway] Add module to manage container namespaces

Signed-off-by: Lunik <[email protected]>

* Fix CI

Signed-off-by: Lunik <[email protected]>

* fix botmeta

Signed-off-by: Lunik <[email protected]>

* fix typo in loop var name

Signed-off-by: Lunik <[email protected]>

* Add missing required lib check

Signed-off-by: Lunik <[email protected]>

* fix integration tests assertions

Signed-off-by: Lunik <[email protected]>

Signed-off-by: Lunik <[email protected]>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Jan 9, 2023
…ions#5416)

* [Scaleway] Add module to manage container namespaces

Signed-off-by: Lunik <[email protected]>

* Fix CI

Signed-off-by: Lunik <[email protected]>

* fix botmeta

Signed-off-by: Lunik <[email protected]>

* fix typo in loop var name

Signed-off-by: Lunik <[email protected]>

* Add missing required lib check

Signed-off-by: Lunik <[email protected]>

* fix integration tests assertions

Signed-off-by: Lunik <[email protected]>

Signed-off-by: Lunik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud integration tests/integration module module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants