Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: pythonisms + a couple of required_if clauses #5367

Merged
merged 8 commits into from
Oct 18, 2022
Merged

consul: pythonisms + a couple of required_if clauses #5367

merged 8 commits into from
Oct 18, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Oct 15, 2022

SUMMARY

Minor refactor on the module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/clustering/consul/consul.py

@ansibullbot
Copy link
Collaborator

cc @sgargan
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug clustering module module plugins plugin (any type) labels Oct 15, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Oct 15, 2022
felixfontein
felixfontein reviewed Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please add a changelog fragment as well.

plugins/modules/clustering/consul/consul.py Outdated Show resolved Hide resolved
plugins/modules/clustering/consul/consul.py Outdated Show resolved Hide resolved
plugins/modules/clustering/consul/consul.py Outdated Show resolved Hide resolved
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 18, 2022
@felixfontein felixfontein merged commit dfe1f9a into ansible-collections:main Oct 18, 2022
@patchback
Copy link

patchback bot commented Oct 18, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/dfe1f9a29eedd05648e77fcc4877194d069bca5a/pr-5367

Backported as #5380

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Oct 18, 2022
@russoz @patchback
consul: pythonisms + a couple of required_if clauses (#5367)
dfd816a 
* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit dfe1f9a)
@patchback patchback bot mentioned this pull request Oct 18, 2022
Merged
felixfontein pushed a commit that referenced this pull request Oct 18, 2022
@patchback @russoz
consul: pythonisms + a couple of required_if clauses (#5367) (#5380)
d6cd908 
* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit dfe1f9a)

Co-authored-by: Alexei Znamensky <[email protected]>
@russoz russoz deleted the consul-minor-refactor branch October 18, 2022 10:47
mpaulon pushed a commit to mpaulon/community.general that referenced this pull request Oct 18, 2022
@russoz @felixfontein @mpaulon
consul: pythonisms + a couple of required_if clauses (ansible-collect…
89d6134 
…ions#5367)

* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
russoz added a commit to russoz-ansible/community.general that referenced this pull request Nov 5, 2022
@russoz @felixfontein
consul: pythonisms + a couple of required_if clauses (ansible-collect…
6b65aeb 
…ions#5367)

* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz @felixfontein
consul: pythonisms + a couple of required_if clauses (ansible-collect…
993e7f6 
…ions#5367)

* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz @felixfontein
consul: pythonisms + a couple of required_if clauses (ansible-collect…
79e0112 
…ions#5367)

* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug clustering module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein