Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5287/f3bcfa5a backport][stable-5] machinectl: include the success command #5312

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 25, 2022

This is a backport of PR #5287 as merged into main (f3bcfa5).

Combines the success command when building the become command. This is consistent with other become plugins.

SUMMARY

Was debugging an issue involving the combination of pipelining and running machinectl as sudo and came across this, though this is not the cause it seemed prudent to submit a PR for it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

machinectl

ADDITIONAL INFORMATION

Combines the success command when building the become command. This is
consistent with other become plugins.

(cherry picked from commit f3bcfa5)
@ansibullbot
Copy link
Collaborator

cc @None
click here for bot help

@ansibullbot ansibullbot added backport become become plugin bug This issue/PR relates to a bug new_contributor Help guide this first time contributor plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 25, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (stable-5@f9fecf1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head f3bcfa5 differs from pull request most recent head e8bdb7c. Consider uploading reports for the commit e8bdb7c to get more accurate results

@@             Coverage Diff             @@
##             stable-5    #5312   +/-   ##
===========================================
  Coverage            ?   45.40%           
===========================================
  Files               ?      978           
  Lines               ?    96245           
  Branches            ?    18354           
===========================================
  Hits                ?    43700           
  Misses              ?    50529           
  Partials            ?     2016           
Flag Coverage Δ
integration 71.18% <0.00%> (?)
sanity 21.23% <0.00%> (?)
stub 0.00% <0.00%> (?)
units 68.15% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 28, 2022
@felixfontein felixfontein merged commit 8beb5d7 into stable-5 Sep 28, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/f3bcfa5a75ef93bb36e3e050d62261ff74a66cd9/pr-5287 branch September 28, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
become become plugin bug This issue/PR relates to a bug new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants