Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5301/a6c8078c backport][stable-5] netcup_dnsapi: Add timeout paramter #5302

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 22, 2022

This is a backport of PR #5301 as merged into main (a6c8078).

SUMMARY

The netcup_dnaspi module relies on python package nc_dnsapi which supports specifying a connection timeout, defaulting to 5 (see https://github.com/nbuchwitz/nc_dnsapi/blob/master/nc_dnsapi/__init__.py#L186)
Being able to specify a value higher than the default is helpful when working on an unstable or high-latency internet connection (e.g. LTE)

This change adds a timeout parameter to the netcup_dnsapi module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netcup_dnsapi

ADDITIONAL INFORMATION

none

* netcup_dnsapi: Add timeout paramter

* add changelog fragment

* Apply suggestions from code review

Co-authored-by: Felix Fontein <[email protected]>

* remove unnecessary newline

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit a6c8078)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (stable-5@baec510). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head a6c8078 differs from pull request most recent head c26974b. Consider uploading reports for the commit c26974b to get more accurate results

@@             Coverage Diff             @@
##             stable-5    #5302   +/-   ##
===========================================
  Coverage            ?   45.43%           
===========================================
  Files               ?      978           
  Lines               ?    96184           
  Branches            ?    18329           
===========================================
  Hits                ?    43697           
  Misses              ?    50474           
  Partials            ?     2013           
Flag Coverage Δ
integration 71.17% <0.00%> (?)
sanity 21.25% <0.00%> (?)
stub 0.00% <0.00%> (?)
units 68.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein felixfontein merged commit b4ae2ce into stable-5 Sep 22, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/a6c8078ccf4578fe2a15e2d97eca716ba6fc9a1d/pr-5301 branch September 22, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants