Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for xfs_quota not properly initializing project quotas #5144

Closed
wants to merge 2 commits into from
Closed

bugfix for xfs_quota not properly initializing project quotas #5144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7917e94
bugfix for xfs_quota not properly initializing project quotas (https:…
MichaelRiss Aug 22, 2022
2f451d1
correct quotation marks in changelog
MichaelRiss Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/5143-fix-xfs-project-quota-initialization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- xfs_quota - the call to "xfs_quota" to set up project quotas was missing the project name and hence failed (https://github.com/ansible-collections/community.general/issues/5143).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- xfs_quota - the call to "xfs_quota" to set up project quotas was missing the project name and hence failed (https://github.com/ansible-collections/community.general/issues/5143).
- xfs_quota - the call to ``xfs_quota`` to set up project quotas was missing the project name and hence failed (https://github.com/ansible-collections/community.general/issues/5143).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Out of curiosity, why is one quotation mark style preferred over the other one? Do these fragments get parsed later with some script/tool which needs this kind of style?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings in these fragments are interpreted as reStructuredText; they end up in CHANGELOG.rst (for exmaple https://github.com/ansible-collections/community.general/blob/stable-5/CHANGELOG.rst).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! I read about .rst files but never worked with them so far.

2 changes: 1 addition & 1 deletion plugins/modules/system/xfs_quota.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def main():
break

if not prj_set and not module.check_mode:
cmd = "project -s"
cmd = "project -s %s" % name
rc, stdout, stderr = exec_quota(module, xfs_quota_bin, cmd, mountpoint)
if rc != 0:
result["cmd"] = cmd
Expand Down