proxmox module_utils: fix get_vm int parse handling

[miyuk]

SUMMARY

When target vm is not exist and get vm by only target vm name, proxmox module raise int parse error.

This PR fix only pattern of vmid is None.
I did't implement other pattern because I guess vmid is only int or None.

Closes #4944

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

proxmox

ADDITIONAL INFORMATION

none

[felixfontein]

Thanks for your contribution! I'm wondering why vmid should ever be None when passed into this function. It might be better to fix that, instead of changing the function to also handle None?

[miyuk]

@felixfontein thanks for your reply.

It might be better to fix that, instead of changing the function to also handle None?

maybe yes.
However, I guess better fix get_vm() than caller because that is parse int error.

If fix caller, affected code is below (proxmox_kvm)

• community.general/plugins/modules/cloud/misc/proxmox_kvm.py

  Line 1374 in c51fa53

  vm = proxmox.get_vm(vmid, ignore_missing=True)

[felixfontein]

But this error happens only because an invalid value is passed to this function, which shouldn't have happened in the first place.

[felixfontein]

(This fix could mask other errors in other uses of this function, since it is a generic utility function that is used by multiple modules, potentially even ones outside of this repository.)

[miyuk]

thanks.
I understood your opinion.
I will fix caller. so please wait abount a week.

[miyuk]

fix on module source code.
please review my code.

[ansibullbot]

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab @tleguern
click here for bot help

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[felixfontein]

The change looks good, it still needs a changelog fragment though.

[felixfontein]

LGTM. If nobody complains, I'll merge this for the next release :)

[russoz]

LGTM