Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1213/64c6f20b backport][stable-1] Add support for HashiCorp Vault JWT auth #1309

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 16, 2020

This is a backport of PR #1213 as merged into main (64c6f20).

This PR is based on the work by @mbrancato in #154. The original pull request needs rebase, and there has been no feedback from @mbrancato since the PR was submitted in April 2020.

SUMMARY

This adds generic JWT/OIDC authentication support for the HashiCorp Vault lookup plugin. The JWT and OIDC auth only differ in the default path their methods will use. I.e., v1/auth/jwt versus v1/auth/oidc.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hashi_vault

ADDITIONAL INFORMATION

The generic JWT auth API is used by the:

JWT auth - https://www.vaultproject.io/api-docs/auth/jwt#jwt-login
GCP auth - https://www.vaultproject.io/api-docs/auth/gcp#login
Kubernetes auth - https://www.vaultproject.io/api-docs/auth/kubernetes#login
even Azure and others...

* Add support for Hashicorp Vault JWT auth

* Add support for HashiCorp Vault JWT auth (continued)

Co-authored-by: Brian Scholer <[email protected]>

Co-authored-by: Mike Brancato <[email protected]>
Co-authored-by: Brian Scholer <[email protected]>
(cherry picked from commit 64c6f20)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added affects_2.10 community_review feature This issue/PR relates to a feature request integration tests/integration lookup lookup plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Nov 16, 2020
@felixfontein felixfontein merged commit b529955 into stable-1 Nov 16, 2020
@felixfontein felixfontein deleted the patchback/backports/stable-1/64c6f20b55fc846ca31f5a6ff4c2215f5b7eccee/pr-1213 branch November 16, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration lookup lookup plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants