-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #996/22005176 backport][stable-1] postgresql_privs: fix the module mistakes a procedure for a function #1006
Conversation
@@ -0,0 +1,2 @@ | |||
bugfixes: | |||
- postgresql_privs - fix the module mistakes a procedure for a function (https://github.com/ansible-collections/community.general/issues/994). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this point to the current PR or the original one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general rule is to put an issue link there. When an issue doesn't exist, we should put a link to a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant rather the ID (994 vs 996)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i understand, this is correct because we have the issue in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, it should be the exact same text as in the original PR. Backports shouldn't modify anything that's not absolutely needed (to resolve conflicts, or adjust to differences between the verison of the code in stable-x
vs. main
).
This is a backport of PR #996 as merged into main (2200517).
SUMMARY
Fixes #994
postgresql_privs: fix the module mistakes a procedure for a function
ISSUE TYPE
COMPONENT NAME
plugins/modules/database/postgresql/postgresql_privs.py