Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #996/22005176 backport][stable-1] postgresql_privs: fix the module mistakes a procedure for a function #1006

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 29, 2020

This is a backport of PR #996 as merged into main (2200517).

SUMMARY

Fixes #994
postgresql_privs: fix the module mistakes a procedure for a function

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/database/postgresql/postgresql_privs.py

…996)

* postgresql_privs: fix the module mistakes a procedure for a function

* add changelog fragment

* fix

(cherry picked from commit 2200517)
@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review database integration tests/integration module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) postgresql stale_ci CI is older than 7 days, rerun before merging tests tests and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI stale_ci CI is older than 7 days, rerun before merging labels Sep 29, 2020
@@ -0,0 +1,2 @@
bugfixes:
- postgresql_privs - fix the module mistakes a procedure for a function (https://github.com/ansible-collections/community.general/issues/994).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this point to the current PR or the original one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general rule is to put an issue link there. When an issue doesn't exist, we should put a link to a PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant rather the ID (994 vs 996)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i understand, this is correct because we have the issue in this case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, it should be the exact same text as in the original PR. Backports shouldn't modify anything that's not absolutely needed (to resolve conflicts, or adjust to differences between the verison of the code in stable-x vs. main).

@Andersson007 Andersson007 merged commit db24f98 into stable-1 Sep 29, 2020
@Andersson007 Andersson007 deleted the patchback/backports/stable-1/220051768be7b430416b423f7fb89a04a07ca94c/pr-996 branch September 29, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review database integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) postgresql tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants