Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker_plugin crash when handling plugin options #447

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #446.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_plugin

@@ -271,7 +271,7 @@ def update_plugin(self):
if not self.check_mode:
try:
data = prepare_options(self.parameters.plugin_options)
self.client.post_json('/plugins/{0}/set', self.preferred_name, data=['{0}={1}'.format(k, v) for k, v in data.items()])
self.client.post_json('/plugins/{0}/set', self.preferred_name, data=data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you are changing the payload contents, it would be Nice to Have (TM) some test to ensure that works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote some tests that I couldn't get to run locally, but apparently they seem to pass in CI... 🤷

@felixfontein felixfontein merged commit a502573 into ansible-collections:main Aug 12, 2022
@felixfontein felixfontein deleted the fix-docker_plugin branch August 12, 2022 17:29
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin_options causes
2 participants