-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker_plugin crash when handling plugin options #447
Fix docker_plugin crash when handling plugin options #447
Conversation
@@ -271,7 +271,7 @@ def update_plugin(self): | |||
if not self.check_mode: | |||
try: | |||
data = prepare_options(self.parameters.plugin_options) | |||
self.client.post_json('/plugins/{0}/set', self.preferred_name, data=['{0}={1}'.format(k, v) for k, v in data.items()]) | |||
self.client.post_json('/plugins/{0}/set', self.preferred_name, data=data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you are changing the payload contents, it would be Nice to Have (TM) some test to ensure that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote some tests that I couldn't get to run locally, but apparently they seem to pass in CI... 🤷
@russoz thanks for reviewing this! |
SUMMARY
Fixes #446.
ISSUE TYPE
COMPONENT NAME
docker_plugin