Fix docker_plugin crash when handling plugin options #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
russoz
reviewed
Aug 12, 2022
| @@ -271,7 +271,7 @@ def update_plugin(self): | |||
| if not self.check_mode: | |||
| try: | |||
| data = prepare_options(self.parameters.plugin_options) | |||
| self.client.post_json('/plugins/{0}/set', self.preferred_name, data=['{0}={1}'.format(k, v) for k, v in data.items()]) | |||
| self.client.post_json('/plugins/{0}/set', self.preferred_name, data=data) | |||
There was a problem hiding this comment.
Given that you are changing the payload contents, it would be Nice to Have (TM) some test to ensure that works.
There was a problem hiding this comment.
I wrote some tests that I couldn't get to run locally, but apparently they seem to pass in CI... 🤷
|
@russoz thanks for reviewing this! |
This was referenced Aug 12, 2022
ghost
mentioned this pull request
1 task
1 task
This was referenced Aug 12, 2022
1 task
1 task
This was referenced Sep 25, 2022
1 task
This was referenced Oct 20, 2022
This was referenced Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #446.
ISSUE TYPE
COMPONENT NAME
docker_plugin