Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor API connection code from Docker SDK for Python #398

Merged
merged 10 commits into from
Jul 2, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Subset of #387: just add the vendored code and some module_utils and plugin_utils.

Once this is merged, I will create one PR per plugin/module from #387.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils
plugin_utils

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some very small things that are not worth withholding approval, nice work!

changelogs/fragments/398-docker-api.yml Outdated Show resolved Hide resolved
Comment on lines +133 to +139
# if self.debug:
# log_file = open('docker.log', 'a')
# if pretty_print:
# log_file.write(json.dumps(msg, sort_keys=True, indent=4, separators=(',', ': ')))
# log_file.write(u'\n')
# else:
# log_file.write(msg + u'\n')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to stay in?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from common.py, having it commented out makes it easy to comment it back in and have some basic logging on debug=true. So as long as it looks the same in common.py it should also be in common_api.py :)

@felixfontein felixfontein merged commit 4d508b4 into ansible-collections:main Jul 2, 2022
@felixfontein felixfontein deleted the docker-py-step-1 branch July 2, 2022 14:40
@felixfontein
Copy link
Collaborator Author

@briantist thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants