Vendor API connection code from Docker SDK for Python #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2022
briantist
approved these changes
Jun 30, 2022
Comment on lines
+133
to
+139
| # if self.debug: | ||
| # log_file = open('docker.log', 'a') | ||
| # if pretty_print: | ||
| # log_file.write(json.dumps(msg, sort_keys=True, indent=4, separators=(',', ': '))) | ||
| # log_file.write(u'\n') | ||
| # else: | ||
| # log_file.write(msg + u'\n') |
There was a problem hiding this comment.
Is this meant to stay in?
There was a problem hiding this comment.
This is copied from common.py, having it commented out makes it easy to comment it back in and have some basic logging on debug=true. So as long as it looks the same in common.py it should also be in common_api.py :)
This is a combination of the latest git version (https://github.com/docker/docker-py/tree/a48a5a9647761406d66e8271f19fab7fa0c5f582) and the version before Python 2.7 support was removed (https://github.com/docker/docker-py/tree/650aad3a5fb84059b392ad450f760ed08143ae3f), including some modifications to work with Ansible module_utils's system (i.e. third-party imports are guarded, and errors are reported during runtime through a new exception MissingRequirementException).
The delete call cannot be called delete() since that method already exists from requests.
Co-authored-by: Brian Scholer <[email protected]>
felixfontein
force-pushed
the
docker-py-step-1
branch
from
ad635bf
to
e181b5c
Compare
|
@briantist thanks a lot for reviewing this! |
This was referenced Aug 12, 2022
ghost
mentioned this pull request
1 task
1 task
This was referenced Aug 12, 2022
1 task
1 task
1 task
This was referenced Sep 25, 2022
1 task
This was referenced Oct 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Subset of #387: just add the vendored code and some module_utils and plugin_utils.
Once this is merged, I will create one PR per plugin/module from #387.
ISSUE TYPE
COMPONENT NAME
module_utils
plugin_utils