Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image_label_mismatch parameter to docker_container #370

Merged
merged 12 commits into from
May 24, 2022

Conversation

RoGryza
Copy link
Contributor

@RoGryza RoGryza commented May 21, 2022

SUMMARY

Fixes #314
Add image_label_mismatch parameter to docker_container to specify the behaviour when the labels provided in the ansible config don't match with the labels from the container's image.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

@github-actions
Copy link

github-actions bot commented May 21, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some comments. Could you also please add a changelog fragment? Thanks :)

plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Show resolved Hide resolved
plugins/modules/docker_container.py Outdated Show resolved Hide resolved
plugins/modules/docker_container.py Show resolved Hide resolved
@RoGryza
Copy link
Contributor Author

RoGryza commented May 22, 2022

Thanks! Addressed all the changes. I added the change fragment but I wasn't sure whether to call it minor_changes or bugfixes

@felixfontein
Copy link
Collaborator

Thanks! Addressed all the changes. I added the change fragment but I wasn't sure whether to call it minor_changes or bugfixes

It's kind of both ;-) minor_changes should definitely be used, what you could do is also add a bugfixes one next to minor_changes. But just minor_changes is also fine (and maybe the best).

@felixfontein felixfontein mentioned this pull request May 24, 2022
@felixfontein
Copy link
Collaborator

The only CI node left (PR comments) can be ignored, so merging now :)

@felixfontein felixfontein merged commit 497c2fd into ansible-collections:main May 24, 2022
@felixfontein
Copy link
Collaborator

@RoGryza thanks for contributing this feature+fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker_container with strict labels comparison ignores base image labels
2 participants