-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image_label_mismatch
parameter to docker_container
#370
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some comments. Could you also please add a changelog fragment? Thanks :)
tests/integration/targets/docker_container/tasks/tests/options.yml
Outdated
Show resolved
Hide resolved
Thanks! Addressed all the changes. I added the change fragment but I wasn't sure whether to call it |
It's kind of both ;-) |
tests/integration/targets/docker_container/tasks/tests/options.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/docker_container/tasks/tests/options.yml
Outdated
Show resolved
Hide resolved
The only CI node left (PR comments) can be ignored, so merging now :) |
@RoGryza thanks for contributing this feature+fix :) |
SUMMARY
Fixes #314
Add
image_label_mismatch
parameter todocker_container
to specify the behaviour when the labels provided in the ansible config don't match with the labels from the container's image.ISSUE TYPE
COMPONENT NAME
docker_container