Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bumped deprecations #363

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Remove the deprecations bumped in #362. I'm creating a PR already now to avoid us forgetting about it again :)

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

docker_stack
common.py

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST wait for the next major release label May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein changed the title [WIP] Remove bumped deprecations Remove bumped deprecations May 20, 2022
@WojciechowskiPiotr WojciechowskiPiotr merged commit 209aeb5 into ansible-collections:main Jul 1, 2022
@WojciechowskiPiotr
Copy link
Collaborator

Merged

@felixfontein felixfontein deleted the deprecations-remove branch July 2, 2022 12:16
@felixfontein
Copy link
Collaborator Author

@WojciechowskiPiotr thanks for reviewing and merging this and the other - unfortunately the merge was too early, since we still need to make another 2.x release from main. I'll revert these two commits from main and will un-revert them once the next 2.x release is out.

felixfontein added a commit that referenced this pull request Jul 2, 2022
felixfontein added a commit that referenced this pull request Jul 2, 2022
@felixfontein
Copy link
Collaborator Author

Both this PR's and #399's commits are back in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change This PR contains a breaking change that MUST wait for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants