Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_container: avoid breakage with Python 3.13 #354

Merged
merged 1 commit into from
May 18, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

This fixes the currently failing Python 3.11 sanity tests (which were just added to ansible-test in devel branch).

The problem is that pipes is removed from Python 3.13's standard library. While looking at that, I noticed that we don't actually use that piece of code, so it can be removed trivially.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

@felixfontein
Copy link
Collaborator Author

CI failures are unrelated.

@felixfontein felixfontein merged commit fb55b1d into ansible-collections:main May 18, 2022
@patchback
Copy link

patchback bot commented May 18, 2022

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/fb55b1d780f9202e38b10b1d96ec18dd624a201f/pr-354

Backported as #355

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the compat branch May 18, 2022 20:22
patchback bot pushed a commit that referenced this pull request May 18, 2022
felixfontein added a commit that referenced this pull request May 19, 2022
(cherry picked from commit fb55b1d)

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant