Skip to content

Commit

Permalink
build: trim trailing whitespace from dockerignore entries
Browse files Browse the repository at this point in the history
Cherry-picked from
docker/docker-py@3ee3a24

Co-authored-by: Clément Loiselet <[email protected]>
  • Loading branch information
felixfontein and Clément Loiselet committed Jul 31, 2022
1 parent c6f7908 commit 8db83bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelogs/fragments/docker-py-changes-1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ bugfixes:
- "modules and plugins communicating directly with the Docker daemon - fix parsing of IPv6 addresses with a port in ``docker_host``. This is only a change relatively to older community.docker 3.0.0 pre-releases, or with respect to Docker SDK for Python < 6.0.0. Docker SDK for Python 6.0.0 also includes this bugfix (https://github.com/ansible-collections/community.docker/pull/434)."
- "modules and plugins communicating directly with the Docker daemon - fix ``ProxyCommand`` handling for SSH connections when not using ``use_ssh_client=true``. This is only a change relatively to older community.docker 3.0.0 pre-releases, or with respect to Docker SDK for Python < 6.0.0. Docker SDK for Python 6.0.0 also includes this change (https://github.com/ansible-collections/community.docker/pull/434)."
- "modules and plugins communicating directly with the Docker daemon - do not create a subshell for SSH connections when using ``use_ssh_client=true``. This is only a change relatively to older community.docker 3.0.0 pre-releases, or with respect to Docker SDK for Python < 6.0.0. Docker SDK for Python 6.0.0 also includes this change (https://github.com/ansible-collections/community.docker/pull/434)."
- "docker_image - when composing the build context, trim trailing whitespace from ``.dockerignore`` entries. This is only a change relatively to older community.docker 3.0.0 pre-releases, or with respect to Docker SDK for Python < 6.0.0. Docker SDK for Python 6.0.0 also includes this change (https://github.com/ansible-collections/community.docker/pull/434)."
minor_changes:
- "modules and plugins communicating directly with the Docker daemon - improve default TLS version selection for Python 3.6 and newer. This is only a change relatively to older community.docker 3.0.0 pre-releases, or with respect to Docker SDK for Python < 6.0.0. Docker SDK for Python 6.0.0 also includes this bugfix (https://github.com/ansible-collections/community.docker/pull/434)."
security_fixes:
Expand Down
3 changes: 3 additions & 0 deletions plugins/module_utils/_api/utils/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ def __init__(self, pattern_str):
@classmethod
def normalize(cls, p):

# Remove trailing spaces
p = p.strip()

# Leading and trailing slashes are not relevant. Yes,
# "foo.py/" must exclude the "foo.py" regular file. "."
# components are not relevant either, even if the whole
Expand Down

0 comments on commit 8db83bb

Please sign in to comment.