[PR #794/ed3a7a0b backport][stable-2] Add abort multipart upload and expire obj del markers to s3 lifecycle #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes #365 #796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of #793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit ed3a7a0)
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/ed3a7a0b0ae86cbcaed733ada1f88a27917e1a09/pr-794
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…listener method to include SSLCertificateId (ansible-collections#864) elb_classic_lb: Add integration tests for - fix return value _format_listener method to include SSLCertificateId SUMMARY Added integration test for ansible-collections#864 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #794 as merged into main (ed3a7a0).
Depends-On: ansible/ansible-zuul-jobs#1247
SUMMARY
Fixes
#365#796ISSUE TYPE
COMPONENT NAME
s3_lifecycle
ADDITIONAL INFORMATION
I have not run integration tests yet because of ansible-collections/amazon.aws#924.
I'm unsure about how to name and structure the new arguments.
Do I nest them to match the API, or flatten them to match existing arguments?