Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda - Wait before updating #857

Merged

Conversation

anjo-swe
Copy link
Contributor

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes #830

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module: lambda

ADDITIONAL INFORMATION

@marknet15
Copy link
Contributor

recheck

@marknet15
Copy link
Contributor

@anjo-swe at the moment there is a in progress move to a new CI server, so two sets of the same tests currently run. I think the one that failed was just an intermittent failure as it passed in 1 set of the run.

the recheck comment will retrigger the tests run

@anjo-swe
Copy link
Contributor Author

@marknet15 thanks for re-checking. Looks like the PR passes all tests and is ready for review at this point

Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean to me. You also need to add a changelog fragment.

@anjo-swe
Copy link
Contributor Author

@markuman added changelog fragment, let me know if anything else is needed

@marknet15
Copy link
Contributor

recheck

@alinabuzachis
Copy link
Contributor

recheck

@marknet15
Copy link
Contributor

recheck

@marknet15
Copy link
Contributor

recheck

@alinabuzachis
Copy link
Contributor

recheck

@alinabuzachis
Copy link
Contributor

recheck

@marknet15
Copy link
Contributor

recheck

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Jan 28, 2022
@marknet15
Copy link
Contributor

@anjo-swe could you possible rebase the branch from upstream main ? The old CI is now disabled I think but to clear the failed check I think it needs a fresh commit to run against.

@anjo-swe
Copy link
Contributor Author

@marknet15 rebased and looks like the build succeeded

@marknet15
Copy link
Contributor

@alinabuzachis @markuman the check gate is all green now that the old CI is disabled, so I think the PR is all good now

@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels Jan 29, 2022
@goneri
Copy link
Member

goneri commented Jan 30, 2022

regate

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ab4bda2 into ansible-collections:main Jan 30, 2022
@patchback
Copy link

patchback bot commented Jan 30, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/ab4bda24245cf103212e0a64bff3cb5b985eb9da/pr-857

Backported as #904

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 30, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes #830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit ab4bda2)
@patchback
Copy link

patchback bot commented Jan 30, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/ab4bda24245cf103212e0a64bff3cb5b985eb9da/pr-857

Backported as #905

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 30, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes #830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit ab4bda2)
tremble pushed a commit that referenced this pull request Jan 30, 2022
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes #830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit ab4bda2)

Co-authored-by: Andreas Jonsson <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 31, 2022
[PR #857/ab4bda24 backport][stable-2] Lambda - Wait before updating

This is a backport of PR #857 as merged into main (ab4bda2).
SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes #830
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION
falsedlah added a commit to falsedlah/community.aws that referenced this pull request Sep 7, 2023
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
tagging docs fragment - comment cleanup (C&P)

SUMMARY
When creating the docs fragment in ansible-collections#844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/doc_fragments/tags.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Lambda - Wait before updating

SUMMARY

Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/

Fixes ansible-collections#830
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

module: lambda
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@ab4bda2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type)
Projects
None yet
6 participants