Update README, CONTRIBUTING.md: freenode -> libera.chat #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Akasurde thanks for reviewing! |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Update README, CONTRIBUTING.md: freenode -> libera.chat Reviewed-by: Andrew Klychkov <[email protected]> https://github.com/Andersson007
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
Update README, CONTRIBUTING.md: freenode -> libera.chat Reviewed-by: Andrew Klychkov <[email protected]> https://github.com/Andersson007
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
… default value for instance_type (ansible-collections#587) ec2_instance: Fix launch template condition, handle launch template - default value for instance_type SUMMARY The launch_template option in ec2_instance has a broken condition. Also the launch_template option defaults the instance_type to t2.micro if not specified and ignores the instance_type specified in the launch_template as said in the issue ansible-collections#451. Fixes ansible-collections#451 ansible-collections#462 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION The change does not break existing functionality as tested by the integration test run locally. Related to the condition fix in community.aws: ansible-collections#111 Ran the following playbook to verify the change. # create a launch template called "test-launch-template" - name: create test launch template community.aws.ec2_launch_template: template_name: test-launch-template image_id: ami-002068ed284xxxxxx instance_type: t3a.small network_interfaces: - associate_public_ip_address: no delete_on_termination: yes device_index: 0 groups: - sg-xxxxxxxxxxxxxxxxxx subnet_id: subnet-xxxxxxxxxxxxxxxxxx region: us-east-2 block_device_mappings: - device_name: /dev/sdb ebs: volume_size: 5 volume_type: gp3 delete_on_termination: true encrypted: yes - device_name: /dev/sdc ebs: volume_size: 2 volume_type: gp2 delete_on_termination: true encrypted: no tags: ssome: tags # launch a ec2 instance using launch template created earlier - launches t3a.small instance as expected - name: test launch template usage ec2_instance: wait: yes name: "test-instance-mk-t3a.small" launch_template: name: test-launch-template vpc_subnet_id: subnet-xxxxxxxxxxxxxxxxxx # launch ec2 instance using launch template created earlier - override instance type to be launch to t3.xlarge - name: test launch template usage - override instance type ec2_instance: wait: yes name: "test-instance-mk-t3.xlarge" instance_type: t3.xlarge launch_template: name: test-launch-template vpc_subnet_id: subnet-xxxxxxxxxxxxxxxxxx Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Emanuele Leopardi <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible-community/community-topics#19
ISSUE TYPE
COMPONENT NAME
README.md