Solves 494: added destructor to ssm connection plugin

[Chilinot]

SUMMARY

Fixes #494

Adds destructor to the SSM connection plugin to ensure connections are properly cleaned up after usage.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

SSM connection plugin

[tremble]

Hi @Chilinot,

Thanks for taking the time to dig into the issue and open this PR. If possible please could you add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

The change itself looks sensible.

[tremble]

@hgrgic you reported also experiencing the issue on #494 if possible please could you test the change in this PR and see if it fixes the issue you're seeing.

[hgrgic]

Hi @tremble and @Chilinot. Thanks for this update.

I have tested the proposed fix with my playbooks. Immediately after adding the proposed change I noticed that sessions were terminated properly. At the same time, looking in the AWS Session Manager console, under sessions, at most time I saw only 1 connection being open.

I have repeated the test with the same playbook but before repeating I have removed the proposed change. In this instance I saw more than 20 connection remaining open even after the execution of playbooks has finished. This tells me that the fix is indeed effective.

I recommend merging this PR as soon as possible!

[Chilinot]

@tremble I have now added a changelog fragment as required.

[tremble]

LGTM - I'll let the test suites do their thing and hopefully we can get this merged.

[tremble]

Tests didn't run in zuul for some reason. Tested locally and they still pass.

[hgrgic]

@tremble What is usually the expected cadence for this merged fix to be included in a release?

[tremble]

Our last release was almost 2 months ago, I'd expect 1.5.0 to land 'soon'.