Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded error #446

Merged
merged 1 commit into from
Feb 25, 2021
Merged

ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded error #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/446-ec2_vpc_nat_gateway_info_stability.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- ec2_vpc_nat_gateway_info - solve RequestLimitExceeded error by adding retry decorator (https://github.com/ansible-collections/community.aws/pull/446)
5 changes: 3 additions & 2 deletions plugins/modules/ec2_vpc_nat_gateway_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
pass # Handled by AnsibleAWSModule

from ansible.module_utils._text import to_native
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import AWSRetry
from ansible_collections.amazon.aws.plugins.module_utils.core import AnsibleAWSModule
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import camel_dict_to_snake_dict
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import ansible_dict_to_boto3_filter_list
Expand All @@ -102,7 +103,7 @@ def get_nat_gateways(client, module, nat_gateway_id=None):
params['NatGatewayIds'] = module.params.get('nat_gateway_ids')

try:
result = json.loads(json.dumps(client.describe_nat_gateways(**params), default=date_handler))
result = json.loads(json.dumps(client.describe_nat_gateways(aws_retry=True, **params), default=date_handler))
except Exception as e:
module.fail_json(msg=to_native(e))

Expand Down Expand Up @@ -131,7 +132,7 @@ def main():
date='2021-12-01', collection_name='community.aws')

try:
connection = module.client('ec2')
connection = module.client('ec2', retry_decorator=AWSRetry.jittered_backoff())
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
module.fail_json_aws(e, msg='Failed to connect to AWS')

Expand Down