Initial tests for kinesis_stream #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyler-2
reviewed
Apr 21, 2020
Tyler-2
reviewed
Apr 21, 2020
Tyler-2
reviewed
Apr 21, 2020
|
Man I would just comment out the failing check_mode tests, since they're exposing previously-unknown bugs but not introducing any, create issues for the bad check_modes, and merge. Then we'd have tests for most of the module merged and would unblock bugfix PRs that are more serious. I'd make it a requirement of those bugfix PRs to reactivate and pass the relevant check_mode tests. But that's probably why I don't run any repositories... |
|
@Tyler-2 My intention is to
|
tremble
changed the title
ansibullbot
added
affects_2.10
community_review
feature
This was referenced Aug 22, 2020
jillr
reviewed
Oct 6, 2020
Co-authored-by: Jill R <[email protected]>
jillr
approved these changes
Oct 8, 2020
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Initial tests for kinesis_stream * Add exceptions for broken check_mode behaviour (idemmpotency) * kinesis_stream requires shards to be defined, update the docs to match * Add tests for tagging and retention period * Yet more tests (and bugs) * Disable Kinesis KMS tests - not supported in CI right now * Apply minor changes from review Co-authored-by: Jill R <[email protected]> Co-authored-by: Jill R <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Initial tests for kinesis_stream * Add exceptions for broken check_mode behaviour (idemmpotency) * kinesis_stream requires shards to be defined, update the docs to match * Add tests for tagging and retention period * Yet more tests (and bugs) * Disable Kinesis KMS tests - not supported in CI right now * Apply minor changes from review Co-authored-by: Jill R <[email protected]> Co-authored-by: Jill R <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
``aws_s3`` copy to object SUMMARY add option to aws_s3 module to copy object existing on Amazon S3 Closes: ansible-collections#42 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_s3 ADDITIONAL INFORMATION - name: copy from source to destination aws_s3: bucket: "{{ dest }}" mode: copy object: destination.txt copy_src: bucket: "{{ src }}" object: source.txt Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Initial tests for kinesis_stream
ISSUE TYPE
COMPONENT NAME
kinesis_stream
ADDITIONAL INFORMATION
Make sure we've got some tests for #27