Flag aws_ssm as unstable rather than disabled #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests blocked by mattclay/aws-terminator#115 |
tremble
changed the title
ansibullbot
added
affects_2.10
bug
jillr
reviewed
Nov 23, 2020
...egration/targets/connection_aws_ssm/aws_ssm_integration_test_setup/templates/aws-env-vars.j2
Show resolved
Hide resolved
tremble
force-pushed
the
unstable/aws_ssm
branch
from
dd7cebe
to
a111f18
Compare
tremble
changed the title
tremble
force-pushed
the
unstable/aws_ssm
branch
from
4e242a4
to
90d758b
Compare
|
@jillr I've been tinkering with this and I'm still hitting a few things:
The version I've just uploaded does work with Python 3.x when aws-terminator doesn't delete things. You mentioned on IRC about increasing the aws-terminator delays. Ultimately it's in our interest to have more comprehensive stable test suites, even if certain modules those tests are slow. I've opened mattclay/aws-terminator#117 to get the conversation going. Since the vast bulk of our tests do clean-up, and the instances we use are pretty small the cost implications should be minimal. |
tremble
force-pushed
the
unstable/aws_ssm
branch
from
b0e0742
to
977736c
Compare
tremble
changed the title
Reduce the delay waiting on the EC2 instances
tremble
force-pushed
the
unstable/aws_ssm
branch
from
977736c
to
639c5ff
Compare
|
@jillr I've been tinkering with this for a while. Windows Instances take way too long to finish booting and get ready. I've disabled the Windows pieces so we're at least testing this on Linux. How do you feel about enabling these tests with Windows disabled? |
tremble
changed the title
jillr
approved these changes
Feb 15, 2021
ethemcemozkan
pushed a commit
to ethemcemozkan/community.aws
that referenced
this pull request
Feb 18, 2021
* Flag aws_ssm as unstable rather than disabled * Try tweaking the policy * no security_token * Use module_defaults rather than fact hack * Fix session token env var * Move bucket creation to avoid aws-terminator whacking it. * Change the order of Instance creation, Windows takes longer to start. * Add reset call to aws_ssm * Add a wait_for_connection call at the start of the connection tests. Reduce the delay waiting on the EC2 instances * Explicitly call community.aws.aws_ssm - looks like 2.9 isn't redirecting properly * Try running SSM connection tests in parallel. * Delay a little more * Turn file names into a variable, and make sure they're unique to the host. * Try bumping up the instance size * More delays... * Remove unused imports * Move botocore import into HAS_BOTO3 try block * Make sure that path_unescaped initial string is unicode because out_path can be * Don't wait for the Windows VM before starting the Linux one * Add a note why the test is 'unstable' * Use EBS optimized volumes to improve Windows boot speed. * Try disabling the Windows connection test - Windows is very slow to start * instances sometimes isn't there if the host took to long to start, use instance_ids * changelog * Remove duplicate wait * Move to more modern instance type * Don't try installing boto, it's already available in the images * remove debugging * Remove old (unused) inventory templates * Add comment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Flag aws_ssm as unstable rather than disabled * Try tweaking the policy * no security_token * Use module_defaults rather than fact hack * Fix session token env var * Move bucket creation to avoid aws-terminator whacking it. * Change the order of Instance creation, Windows takes longer to start. * Add reset call to aws_ssm * Add a wait_for_connection call at the start of the connection tests. Reduce the delay waiting on the EC2 instances * Explicitly call community.aws.aws_ssm - looks like 2.9 isn't redirecting properly * Try running SSM connection tests in parallel. * Delay a little more * Turn file names into a variable, and make sure they're unique to the host. * Try bumping up the instance size * More delays... * Remove unused imports * Move botocore import into HAS_BOTO3 try block * Make sure that path_unescaped initial string is unicode because out_path can be * Don't wait for the Windows VM before starting the Linux one * Add a note why the test is 'unstable' * Use EBS optimized volumes to improve Windows boot speed. * Try disabling the Windows connection test - Windows is very slow to start * instances sometimes isn't there if the host took to long to start, use instance_ids * changelog * Remove duplicate wait * Move to more modern instance type * Don't try installing boto, it's already available in the images * remove debugging * Remove old (unused) inventory templates * Add comment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Flag aws_ssm as unstable rather than disabled * Try tweaking the policy * no security_token * Use module_defaults rather than fact hack * Fix session token env var * Move bucket creation to avoid aws-terminator whacking it. * Change the order of Instance creation, Windows takes longer to start. * Add reset call to aws_ssm * Add a wait_for_connection call at the start of the connection tests. Reduce the delay waiting on the EC2 instances * Explicitly call community.aws.aws_ssm - looks like 2.9 isn't redirecting properly * Try running SSM connection tests in parallel. * Delay a little more * Turn file names into a variable, and make sure they're unique to the host. * Try bumping up the instance size * More delays... * Remove unused imports * Move botocore import into HAS_BOTO3 try block * Make sure that path_unescaped initial string is unicode because out_path can be * Don't wait for the Windows VM before starting the Linux one * Add a note why the test is 'unstable' * Use EBS optimized volumes to improve Windows boot speed. * Try disabling the Windows connection test - Windows is very slow to start * instances sometimes isn't there if the host took to long to start, use instance_ids * changelog * Remove duplicate wait * Move to more modern instance type * Don't try installing boto, it's already available in the images * remove debugging * Remove old (unused) inventory templates * Add comment
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Flag aws_ssm as unstable rather than disabled * Try tweaking the policy * no security_token * Use module_defaults rather than fact hack * Fix session token env var * Move bucket creation to avoid aws-terminator whacking it. * Change the order of Instance creation, Windows takes longer to start. * Add reset call to aws_ssm * Add a wait_for_connection call at the start of the connection tests. Reduce the delay waiting on the EC2 instances * Explicitly call community.aws.aws_ssm - looks like 2.9 isn't redirecting properly * Try running SSM connection tests in parallel. * Delay a little more * Turn file names into a variable, and make sure they're unique to the host. * Try bumping up the instance size * More delays... * Remove unused imports * Move botocore import into HAS_BOTO3 try block * Make sure that path_unescaped initial string is unicode because out_path can be * Don't wait for the Windows VM before starting the Linux one * Add a note why the test is 'unstable' * Use EBS optimized volumes to improve Windows boot speed. * Try disabling the Windows connection test - Windows is very slow to start * instances sometimes isn't there if the host took to long to start, use instance_ids * changelog * Remove duplicate wait * Move to more modern instance type * Don't try installing boto, it's already available in the images * remove debugging * Remove old (unused) inventory templates * Add comment
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…tions#295) * Initial integration test for aws_account_attribute * Add AWS retries to aws_account_attribute * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Flag aws_ssm as unstable rather than disabled
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
If possible #278 should trigger integration tests...