Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix element type for load_balancers in ecs_service #286

Merged
merged 2 commits into from
Nov 12, 2020
Merged

fix element type for load_balancers in ecs_service #286

merged 2 commits into from
Nov 12, 2020

Conversation

markuman
Copy link
Member

SUMMARY

fixes #265

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_service

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code doesn't make any assumptions about the content of load_balancers, so it's not 100% clear to me from just looking at the code, but it looks very unrealistic that this should be a string and not a dict.

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble merged commit 3f76266 into ansible-collections:main Nov 12, 2020
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs_service load_balancers not working with container port
3 participants