[PR #2450/0797ce3e backport][stable-11] ACA-6402 Modify autoscaling_policy module to enforce floats for StepScaling bounds#2454
Conversation
…caling bounds (#2450) SUMMARY This pull request fixes a bug in the autoscaling_policy module by allowing the lower_bound and upper_bound parameters in step_adjustments to accept float values instead of just integers. This change ensures more flexibility and accuracy when configuring autoscaling policies. Bugfix for step scaling bounds: Updated the autoscaling_policy module to allow lower_bound and upper_bound in step_adjustments to be floats, both in the module argument specification and in the main function definition. [1] [2] Added a changelog entry documenting that lower_bound and upper_bound now accept float types. Fixes #2355. ISSUE TYPE Bugfix Pull Request Reviewed-by: Matthew Johnson Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Chyna Sanders Reviewed-by: Bikouo Aubin (cherry picked from commit 0797ce3)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 25s (non-voting) |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 22s (non-voting) |
Bumps the github-actions group with 3 updates: ansible-community/ansible-test-gh-action, actions/github-script and actions/checkout. Updates ansible-community/ansible-test-gh-action from 1.17.0 to 1.18.0 Release notes Sourced from ansible-community/ansible-test-gh-action's releases. v1.18.0 What's Changed Project Changes Support ansible-core 2.20 and 2.21, bump default ansible-core version to 2.21 by @felixfontein in ansible-community/ansible-test-gh-action#125 Dependencies Bump codecov/codecov-action from 4.5.0 to 5.4.3 by @dependabot[bot] in ansible-community/ansible-test-gh-action#101 Bump actions/checkout from 4 to 5 by @dependabot[bot] in ansible-community/ansible-test-gh-action#104 Bump codecov/codecov-action from 5.4.3 to 5.5.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#105 Bump codecov/codecov-action from 5.5.0 to 5.5.1 by @dependabot[bot] in ansible-community/ansible-test-gh-action#107 Bump actions/setup-python from 5 to 6 by @dependabot[bot] in ansible-community/ansible-test-gh-action#108 Bump actions/checkout from 5 to 6 by @dependabot[bot] in ansible-community/ansible-test-gh-action#110 Bump codecov/codecov-action from 5.5.1 to 5.5.2 by @dependabot[bot] in ansible-community/ansible-test-gh-action#111 Bump codecov/codecov-action from 5.5.2 to 5.5.3 by @dependabot[bot] in ansible-community/ansible-test-gh-action#114 Bump codecov/codecov-action from 5.5.3 to 6.0.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#115 Bump codecov/codecov-action from 6.0.0 to 6.0.1 by @dependabot[bot] in ansible-community/ansible-test-gh-action#119 Bump codecov/codecov-action from 6.0.1 to 7.0.0 by @dependabot[bot] in ansible-community/ansible-test-gh-action#122 Bump actions/checkout from 6 to 7 by @dependabot[bot] in ansible-community/ansible-test-gh-action#126 Full Changelog: ansible-community/ansible-test-gh-action@v1.17.0...v1.18.0 Commits 6ded727 Merge pull request #126 from ansible-community/dependabot/github_actions/acti... e0d4c98 Bump actions/checkout from 6 to 7 6c86f3f Merge pull request #125 from felixfontein/ansible-core 48b041f Merge pull request #122 from ansible-community/dependabot/github_actions/code... 3272591 Merge pull request #124 from felixfontein/fix-pre-commit c0626df Bump default ansible-core to 2.21 7dfd27a Support ansible-core 2.20 and 2.21 c8e46ea Bump pre-commit flake8 additional deps 13e4993 Bump codecov/codecov-action from 6.0.1 to 7.0.0 8b1ac34 Merge pull request #119 from ansible-community/dependabot/github_actions/code... Additional commits viewable in compare view Updates actions/github-script from 7.1.0 to 9.0.0 Release notes Sourced from actions/github-script's releases. v9.0.0 New features: getOctokit factory function — Available directly in the script context. Create additional authenticated Octokit clients with different tokens for multi-token workflows, GitHub App tokens, and cross-org access. See Creating additional clients with getOctokit for details and examples. Orchestration ID in user-agent — The ACTIONS_ORCHESTRATION_ID environment variable is automatically appended to the user-agent string for request tracing. Breaking changes: require('@actions/github') no longer works in scripts. The upgrade to @actions/github v9 (ESM-only) means require('@actions/github') will fail at runtime. If you previously used patterns like const { getOctokit } = require('@actions/github') to create secondary clients, use the new injected getOctokit function instead — it's available directly in the script context with no imports needed. getOctokit is now an injected function parameter. Scripts that declare const getOctokit = ... or let getOctokit = ... will get a SyntaxError because JavaScript does not allow const/let redeclaration of function parameters. Use the injected getOctokit directly, or use var getOctokit = ... if you need to redeclare it. If your script accesses other @actions/github internals beyond the standard github/octokit client, you may need to update those references for v9 compatibility. What's Changed Add ACTIONS_ORCHESTRATION_ID to user-agent string by @Copilot in actions/github-script#695 ci: use deployment: false for integration test environments by @salmanmkc in actions/github-script#712 feat!: add getOctokit to script context, upgrade @actions/github v9, @octokit/core v7, and related packages by @salmanmkc in actions/github-script#700 New Contributors @Copilot made their first contribution in actions/github-script#695 Full Changelog: actions/github-script@v8.0.0...v9.0.0 v8.0.0 What's Changed Update Node.js version support to 24.x by @salmanmkc in actions/github-script#637 README for updating actions/github-script from v7 to v8 by @sneha-krip in actions/github-script#653⚠️ Minimum Compatible Runner Version v2.327.1 Release Notes Make sure your runner is updated to this version or newer to use this release. New Contributors @salmanmkc made their first contribution in actions/github-script#637 @sneha-krip made their first contribution in actions/github-script#653 Full Changelog: actions/github-script@v7.1.0...v8.0.0 Commits 3a2844b Merge pull request #700 from actions/salmanmkc/expose-getoctokit + prepare re... ca10bbd fix: use @octokit/core/types import for v7 compatibility 86e48e2 merge: incorporate main branch changes c108472 chore: rebuild dist for v9 upgrade and getOctokit factory afff112 Merge pull request #712 from actions/salmanmkc/deployment-false + fix user-ag... ff8117e ci: fix user-agent test to handle orchestration ID 81c6b78 ci: use deployment: false to suppress deployment noise from integration tests 3953caf docs: update README examples from @v8 to @v9, add getOctokit docs and v9 brea... c17d55b ci: add getOctokit integration test job a047196 test: add getOctokit integration tests via callAsyncFunction Additional commits viewable in compare view Updates actions/checkout from 6.0.3 to 7.0.0 Release notes Sourced from actions/checkout's releases. v7.0.0 What's Changed block checking out fork pr for pull_request_target and workflow_run by @aiqiaoy in actions/checkout#2454 Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 in the minor-actions-dependencies group across 1 directory by @dependabot[bot] in actions/checkout#2458 Bump flatted from 3.3.1 to 3.4.2 by @dependabot[bot] in actions/checkout#2460 Bump js-yaml from 4.1.0 to 4.2.0 by @dependabot[bot] in actions/checkout#2461 Bump @actions/core and @actions/tool-cache and Remove uuid by @dependabot[bot] in actions/checkout#2459 upgrade module to esm and update dependencies by @aiqiaoy in actions/checkout#2463 Bump the minor-npm-dependencies group across 1 directory with 3 updates by @dependabot[bot] in actions/checkout#2462 getting ready for checkout v7 release by @aiqiaoy in actions/checkout#2464 update error wording by @aiqiaoy in actions/checkout#2467 New Contributors @aiqiaoy made their first contribution in actions/checkout#2454 Full Changelog: actions/checkout@v6.0.3...v7.0.0 Changelog Sourced from actions/checkout's changelog. Changelog v7.0.0 Block checking out fork PR for pull_request_target and workflow_run by @aiqiaoy in actions/checkout#2454 Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 in the minor-actions-dependencies group across 1 directory by @dependabot[bot] in actions/checkout#2458 Bump flatted from 3.3.1 to 3.4.2 by @dependabot[bot] in actions/checkout#2460 Bump js-yaml from 4.1.0 to 4.2.0 by @dependabot[bot] in actions/checkout#2461 Bump @actions/core and @actions/tool-cache and Remove uuid by @dependabot[bot] in actions/checkout#2459 upgrade module to esm and update dependencies by @aiqiaoy in actions/checkout#2463 Bump the minor-npm-dependencies group across 1 directory with 3 updates by @dependabot[bot] in actions/checkout#2462 v6.0.3 Fix checkout init for SHA-256 repositories by @yaananth in actions/checkout#2439 fix: expand merge commit SHA regex and add SHA-256 test cases by @yaananth in actions/checkout#2414 v6.0.2 Fix tag handling: preserve annotations and explicit fetch-tags by @ericsciple in actions/checkout#2356 v6.0.1 Add worktree support for persist-credentials includeIf by @ericsciple in actions/checkout#2327 v6.0.0 Persist creds to a separate file by @ericsciple in actions/checkout#2286 Update README to include Node.js 24 support details and requirements by @salmanmkc in actions/checkout#2248 v5.0.1 Port v6 cleanup to v5 by @ericsciple in actions/checkout#2301 v5.0.0 Update actions checkout to use node 24 by @salmanmkc in actions/checkout#2226 v4.3.1 Port v6 cleanup to v4 by @ericsciple in actions/checkout#2305 v4.3.0 docs: update README.md by @motss in actions/checkout#1971 Add internal repos for checking out multiple repositories by @mouismail in actions/checkout#1977 Documentation update - add recommended permissions to Readme by @benwells in actions/checkout#2043 Adjust positioning of user email note and permissions heading by @joshmgross in actions/checkout#2044 Update README.md by @nebuk89 in actions/checkout#2194 Update CODEOWNERS for actions by @TingluoHuang in actions/checkout#2224 Update package dependencies by @salmanmkc in actions/checkout#2236 v4.2.2 url-helper.ts now leverages well-known environment variables by @jww3 in actions/checkout#1941 Expand unit test coverage for isGhes by @jww3 in actions/checkout#1946 v4.2.1 Check out other refs/* by commit if provided, fall back to ref by @orhantoy in actions/checkout#1924 ... (truncated) Commits 9c091bb update error wording (#2467) 1044a6d getting ready for checkout v7 release (#2464) f028218 Bump the minor-npm-dependencies group across 1 directory with 3 updates (#2462) d914b26 upgrade module to esm and update dependencies (#2463) 537c7ef Bump @actions/core and @actions/tool-cache and Remove uuid (#2459) 130a169 Bump js-yaml from 4.1.0 to 4.2.0 (#2461) 7d09575 Bump flatted from 3.3.1 to 3.4.2 (#2460) 0f9f3aa Bump actions/publish-immutable-action (#2458) f9e715a block checking out fork pr for pull_request_target and workflow_run (#2454) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions Reviewed-by: Mark Chappell
This is a backport of PR #2450 as merged into main (0797ce3).
SUMMARY
This pull request fixes a bug in the
autoscaling_policymodule by allowing thelower_boundandupper_boundparameters instep_adjustmentsto accept float values instead of just integers. This change ensures more flexibility and accuracy when configuring autoscaling policies.Bugfix for step scaling bounds:
autoscaling_policymodule to allowlower_boundandupper_boundinstep_adjustmentsto be floats, both in the module argument specification and in the main function definition. [1] [2]lower_boundandupper_boundnow accept float types.Fixes #2355.
ISSUE TYPE