[WIP] update lamba_alias and lambda_event to use AWSModule.client() #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pjodouin @ryansb @s-hertel @wimnat |
ansibullbot
added
WIP
tremble
force-pushed
the
awsmodule/client/lambda
branch
from
7dfe295
to
92c6c77
Compare
|
Abandoning this. Will cleanup the modules separately and add integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up to #188 as discussed with @jillr
Updates lamba_alias and lambda_event to use the AWSModule.client helper to get boto3 clients.
ISSUE TYPE
COMPONENT NAME
lamba_alias
lambda_event
ADDITIONAL INFORMATION
No tests available and the modules do something 'clever' - investigate adding Integration tests