update module using module_utils/cloudfront_facts.py #1596

abikouo · 2022-11-15T14:08:10Z

Depends-On: ansible-collections/amazon.aws#1265

SUMMARY

update cloudfront_* modules, fix some bugs and add integration tests

ISSUE TYPE

Feature Pull Request

ansibullbot · 2022-11-15T14:34:33Z

cc @jillr @markuman @s-hertel @tremble @wilvk
click here for bot help

softwarefactory-project-zuul · 2022-11-15T14:36:54Z

This change depends on a change that failed to merge.

abikouo · 2022-11-15T15:18:04Z

recheck

softwarefactory-project-zuul · 2022-11-15T15:37:07Z

Build failed.

softwarefactory-project-zuul · 2022-11-15T17:13:34Z

Build failed.

softwarefactory-project-zuul · 2022-11-21T16:05:34Z

Build failed.

softwarefactory-project-zuul · 2022-11-21T16:57:14Z

Build failed.

jillr · 2022-11-21T21:57:09Z

When running the cloudfront_distribution tests to test the terminator PR, they pass but there are 2 distributions remaining in the CI AWS account that are not automatically deleted by the test suite. Please ensure that all resources created by the tests are removed by the tests.

abikouo · 2022-11-22T11:36:22Z

When running the cloudfront_distribution tests to test the terminator PR, they pass but there are 2 distributions remaining in the CI AWS account that are not automatically deleted by the test suite. Please ensure that all resources created by the tests are removed by the tests.

only the second cloudfront distribution was not deleted, I have updated the test. Could you please validate once again in a clean environment? Thanks

softwarefactory-project-zuul · 2022-11-22T11:50:57Z

Build failed.

gravesm · 2022-12-01T16:01:24Z

recheck

softwarefactory-project-zuul · 2022-12-01T16:52:42Z

Build failed.

gravesm · 2022-12-01T16:57:37Z

2022-12-01 16:41:30.567401 | controller | TASK [cloudfront_distribution : check that custom origin uses the provided origin_access_identity] ***
2022-12-01 16:41:30.567408 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/cloudfront_distribution/tasks/main.yml:505
2022-12-01 16:41:30.643578 | controller | fatal: [testhost]: FAILED! => {
2022-12-01 16:41:30.643613 | controller |     "assertion": "update_distribution_with_specific_access_identity.origins['items'].0.s3_origin_config.origin_access_identity == origin_access_identity",

I saw this failure locally, too, but when I re-ran all the tests passed. Something here seems a little flaky.

softwarefactory-project-zuul · 2023-01-10T15:20:35Z

Build succeeded.

softwarefactory-project-zuul · 2023-01-27T09:52:06Z

Build succeeded.

tests/integration/targets/cloudfront_distribution/tasks/main.yml

softwarefactory-project-zuul · 2023-02-01T12:05:36Z

Build succeeded (gate pipeline).

github-actions · 2023-02-01T12:10:42Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Nov 15, 2022

abikouo mentioned this pull request Nov 15, 2022

Terminator policies for CloudFront modules mattclay/aws-terminator#245

Merged

abikouo force-pushed the cloudfront_facts_1 branch from d53b182 to 625f7d4 Compare November 21, 2022 15:46

ansibullbot removed the needs_triage label Nov 21, 2022

abikouo force-pushed the cloudfront_facts_1 branch from 3433d0f to 839036b Compare November 22, 2022 11:34

abikouo force-pushed the cloudfront_facts_1 branch from 839036b to 920e331 Compare January 10, 2023 14:34

abikouo requested review from jillr, tremble and alinabuzachis January 10, 2023 15:21

update module using module_utils/cloudfront_facts.py

a38e0f8

abikouo force-pushed the cloudfront_facts_1 branch from 920e331 to a38e0f8 Compare January 27, 2023 09:24

alinabuzachis reviewed Jan 27, 2023

View reviewed changes

tests/integration/targets/cloudfront_distribution/tasks/main.yml Show resolved Hide resolved

abikouo added the mergeit Merge the PR (SoftwareFactory) label Feb 1, 2023

softwarefactory-project-zuul bot merged commit dbb482c into ansible-collections:main Feb 1, 2023

abikouo deleted the cloudfront_facts_1 branch October 20, 2023 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update module using module_utils/cloudfront_facts.py #1596

update module using module_utils/cloudfront_facts.py #1596

abikouo commented Nov 15, 2022

ansibullbot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

abikouo commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 21, 2022

softwarefactory-project-zuul bot commented Nov 21, 2022

jillr commented Nov 21, 2022

abikouo commented Nov 22, 2022

softwarefactory-project-zuul bot commented Nov 22, 2022

gravesm commented Dec 1, 2022

softwarefactory-project-zuul bot commented Dec 1, 2022

gravesm commented Dec 1, 2022

softwarefactory-project-zuul bot commented Jan 10, 2023

softwarefactory-project-zuul bot commented Jan 27, 2023

softwarefactory-project-zuul bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

update module using module_utils/cloudfront_facts.py #1596

update module using module_utils/cloudfront_facts.py #1596

Conversation

abikouo commented Nov 15, 2022

SUMMARY

ISSUE TYPE

ansibullbot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

abikouo commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 15, 2022

softwarefactory-project-zuul bot commented Nov 21, 2022

softwarefactory-project-zuul bot commented Nov 21, 2022

jillr commented Nov 21, 2022

abikouo commented Nov 22, 2022

softwarefactory-project-zuul bot commented Nov 22, 2022

gravesm commented Dec 1, 2022

softwarefactory-project-zuul bot commented Dec 1, 2022

gravesm commented Dec 1, 2022

softwarefactory-project-zuul bot commented Jan 10, 2023

softwarefactory-project-zuul bot commented Jan 27, 2023

softwarefactory-project-zuul bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

Docs Build 📝