Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cloudfront_info #1352

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 12, 2022

SUMMARY

renames cloudfront_info to cloudfront_distribution_info to match it's pair cloudfront_distribution

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/cloudfront_info.py
plugins/modules/cloudfront_distribution_info.py

ADDITIONAL INFORMATION

Also cleans up the legacy_missing_tests/aliases file

@github-actions
Copy link

github-actions bot commented Jul 12, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 12, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 5m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 37s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 11s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 53s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 11s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 00s
✔️ ansible-test-splitter SUCCESS in 2m 36s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 5m 25s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 43s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 00s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 30s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 08s
✔️ ansible-test-splitter SUCCESS in 2m 41s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 354a287 into ansible-collections:main Jul 13, 2022
@tremble tremble deleted the renames/cloudfront branch September 9, 2022 09:02
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…rameter we're not trying to set (#1406)

s3_bucket - be more forgiving when missing 'get' permissions for a parameter we're not trying to set

SUMMARY
S3 permissions are painfully complex.  Be as forgiving as possible when missing a 'get' permission on a parameter we're not trying to set.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
Related to ansible-collections#1352

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants