Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WAF (v1) modules #1299

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 2, 2022

SUMMARY

In line with the new naming guidelines drop "aws_" from the start of the WAFv1 modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/aws_waf_condition.py
plugins/modules/aws_waf_info.py
plugins/modules/aws_waf_rule.py
plugins/modules/aws_waf_web_acl.py

plugins/modules/waf_condition.py
plugins/modules/waf_info.py
plugins/modules/waf_rule.py
plugins/modules/waf_web_acl.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 29s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 23s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 29s
✔️ ansible-test-splitter SUCCESS in 2m 27s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 24s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 34s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 35s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 49s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 45s
✔️ ansible-test-splitter SUCCESS in 2m 21s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 1299,f74d464a87e1ebca8024cdf059f5778e55336360

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 14s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 04s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 10s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 47s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 30s
✔️ ansible-test-splitter SUCCESS in 2m 46s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 16s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 16s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 49s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 25s
✔️ ansible-test-splitter SUCCESS in 2m 29s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3bb2a70 into ansible-collections:main Jul 4, 2022
@tremble tremble deleted the renames/waf branch July 7, 2022 19:22
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Support multiple VPCs for a route53_zone

SUMMARY

Added support for multiple VPCs to be applied to route53_zone module
Fixes ansible-collections#1299

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53_zone
ADDITIONAL INFORMATION



    - name: create zone
      amazon.aws.route53_zone:
        zone: mynewzone.sandbox.example.com
        state: present
        vpcs:
          - id: vpc-123456
            region: eu-west-2
          - id: vpc-234567
            region: eu-west-2

Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants