route53_info: Add snake_cased return key,values and a deprecation message #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandar242
requested review from
tremble,
markuman,
jillr,
alinabuzachis and
jatorcasso
ansibullbot
added
bug
This comment was marked as off-topic.
This comment was marked as off-topic.
|
recheck |
tremble
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
I'm good with this change. I've submitted ansible/ansible-zuul-jobs#1564 to drop the 2.9 Sanity tests as was discussed in the last Ansible AWS community meeting. Assuming we can get the tests dropped I don't think there's value in updating the ignore files for 4.x/3.x
|
recheck |
jatorcasso
reviewed
Jun 14, 2022
alinabuzachis
approved these changes
Jun 14, 2022
yes, that makes sense. I am planning to open a different PR for adding RETURN data block once this PR is merged. |
jatorcasso
approved these changes
Jun 14, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1237 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
…sage (#1236) route53_info: Add snake_cased return key,values and a deprecation message Depends-On: ansible/ansible-zuul-jobs#1564 SUMMARY Add snake_case return values and a deprecation message for existing CamelCase return values. Route53_info currently returns CamelCase values, to have uniformity along all *_info modules in terms of return values, it should return snake_case values instead. Proposed change should make addition of snake_case return values and the deprecation message provides time for users to upgrade their playbooks to avoid breaking existing playbooks due to the proposed change. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION This PR is relation to the initiative for having updated developer guidelines for *_info modules specifically related to guidelines for deprecating return values. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 3df423a)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
…sage (#1236) (#1237) [PR #1236/3df423ac backport][stable-3] route53_info: Add snake_cased return key,values and a deprecation message This is a backport of PR #1236 as merged into main (3df423a). Depends-On: ansible/ansible-zuul-jobs#1564 SUMMARY Add snake_case return values and a deprecation message for existing CamelCase return values. Route53_info currently returns CamelCase values, to have uniformity along all *_info modules in terms of return values, it should return snake_case values instead. Proposed change should make addition of snake_case return values and the deprecation message provides time for users to upgrade their playbooks to avoid breaking existing playbooks due to the proposed change. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION This PR is relation to the initiative for having updated developer guidelines for *_info modules specifically related to guidelines for deprecating return values. Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
route53_info: Add RETURN block SUMMARY Currently route53_info is mising a return block. This is a follow up on #1236 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]>
This was referenced Jun 22, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
…thout updating existing health check (#1143) (#1324) [PR #1143/8d3fec8e backport][stable-4] route53_health_check: Add feature to create multiple health checks without updating existing health check This is a backport of PR #1143 as merged into main (8d3fec8). SUMMARY Might fix #88 Update [06/30/2022]: This PR adds three new parameters to route53_health_check module. health_check_id=dict(type='str', aliases=['id'], required=False), health_check_name=dict(type='str', aliases=['name'], required=False), use_unique_names=dict(type='bool', required=False), health_check_id (alias id): when set, can be used to update and also delete health checks. use_unique_names and health_check_name (alias name): these are used together to make use of health check name as a unique identifier to create/update/delete health check and also assign a name to the health check. Update [05/20/2022]: Based on discussion between 15 May to 19 May below, the approach of adding ignore_existing parameter has been discarded for the time being. The progress on this WIP PR put on hold until route53_info return value issue gets resolved. #1236 Added parameter ignore_existing that allows to create multiple route53 healthchecks with similar parameters instead of updating existing healthcheck (example: create multiple route53 healthchecks with different paths to same server). ISSUE TYPE Feature Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION Consider following example from the issue. - name: set up route53 health checks connection: local become: false route53_health_check: failure_threshold: 3 ip_address: '{{ ip_address }}' port: 80 request_interval: 30 resource_path: '{{ item }}' state: present type: HTTP #ignore_existing: True register: result with_items: - /some_status1 - /other_status2 With ignore_exisitng parameter, it will create two healthchecks to same sever with different resource_path. Without ignore_existing parameter, it will create first healthcheck to sever, then start creating the second healthcheck but as it's having same server/ip_address, it updates the existing healthcheck instead, so creates only single healthcheck at the end of the task. Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
…1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on #1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
…1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on #1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit d7f3862)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
…1322) (#1327) [PR #1322/d7f38627 backport][stable-4] route53_info: Add snake_cased return key,values to remaining methods This is a backport of PR #1322 as merged into main (d7f3862). SUMMARY Following up on #1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…sage (ansible-collections#1236) route53_info: Add snake_cased return key,values and a deprecation message Depends-On: ansible/ansible-zuul-jobs#1564 SUMMARY Add snake_case return values and a deprecation message for existing CamelCase return values. Route53_info currently returns CamelCase values, to have uniformity along all *_info modules in terms of return values, it should return snake_case values instead. Proposed change should make addition of snake_case return values and the deprecation message provides time for users to upgrade their playbooks to avoid breaking existing playbooks due to the proposed change. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION This PR is relation to the initiative for having updated developer guidelines for *_info modules specifically related to guidelines for deprecating return values. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3df423a
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
route53_info: Add RETURN block SUMMARY Currently route53_info is mising a return block. This is a follow up on ansible-collections#1236 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@6e7f150
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on ansible-collections#1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@d7f3862
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_eni_info/tests: add unit-tests SUMMARY Add the unit-test coverage of the ec2_eni_info module. break up list_eni to move connection.describe_network_interfaces to separate method. refactor ec2_eni_info module COMPONENT NAME ec2_eni_info Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1564
SUMMARY
Add snake_case return values and a deprecation message for existing CamelCase return values.
Route53_info currently returns CamelCase values, to have uniformity along all *_info modules in terms of return values, it should return snake_case values instead.
Proposed change should make addition of snake_case return values and the deprecation message provides time for users to upgrade their playbooks to avoid breaking existing playbooks due to the proposed change.
ISSUE TYPE
COMPONENT NAME
route53_info
ADDITIONAL INFORMATION
This PR is relation to the initiative for having updated developer guidelines for *_info modules specifically related to guidelines for deprecating return values.