Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_asg_lifecycle_hook: add integration tests #1048

Merged
merged 4 commits into from
Apr 12, 2022
Merged

ec2_asg_lifecycle_hook: add integration tests #1048

merged 4 commits into from
Apr 12, 2022

Conversation

mandar242
Copy link
Contributor

SUMMARY

Adding integration tests to ec2_asg_lifecycle_hook module.
Fixing idempotency.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_asg_lifecycle_hook

@mandar242 mandar242 mentioned this pull request Apr 5, 2022
Merged
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble @tsiganenok
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Apr 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@mandar242 mandar242 force-pushed the add-ec2_asg_lifecycle_hook-integration-tests branch from adfb6f9 to aeba0ef Compare April 6, 2022 04:27
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jillr
Copy link
Collaborator

jillr commented Apr 8, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@mandar242 mandar242 changed the title [WIP] ec2_asg_lifecycle_hook: add integration tests ec2_asg_lifecycle_hook: add integration tests Apr 8, 2022
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Apr 8, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jillr
jillr approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @mandar242, just a small docs request then this LGTM

plugins/modules/ec2_asg_lifecycle_hook.py Show resolved Hide resolved
jatorcasso
jatorcasso approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Apr 12, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9357932 into ansible-collections:main Apr 12, 2022
@mandar242 mandar242 deleted the add-ec2_asg_lifecycle_hook-integration-tests branch April 12, 2022 00:55
@markuman markuman mentioned this pull request Apr 12, 2022
Closed
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

@jatorcasso jatorcasso jatorcasso approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandar242 @ansibullbot @jillr @jatorcasso