Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds_instance should explicitly set no_log=False for force_update_password #241

Closed
tremble opened this issue Sep 24, 2020 · 0 comments · Fixed by #244
Closed

rds_instance should explicitly set no_log=False for force_update_password #241

tremble opened this issue Sep 24, 2020 · 0 comments · Fixed by #244

Comments

@tremble
Copy link
Contributor

tremble commented Sep 24, 2020 •
edited
Loading

SUMMARY

Because force_update_password doesn't contain sensitive information (but matches the pattern "password") we need to explicitly set no_log=False to avoid a warning for users.

(spotted on #240)

ISSUE TYPE
  • Bug Report
COMPONENT NAME

rds_instance

ANSIBLE VERSION
ansible 2.9.6
CONFIGURATION
ANSIBLE_SSH_ARGS(env: ANSIBLE_SSH_ARGS) = -F /home/skoranda/CILogon2/comanage-registry-ansible/ssh_config -C -o ControlMaster=auto -o ControlPersist=3600s
ANSIBLE_SSH_CONTROL_PATH(/home/skoranda/CILogon2/comanage-registry-ansible/ansible.cfg) = ssh_mux_%%h_%%p
DEFAULT_HOST_LIST(env: ANSIBLE_INVENTORY) = ['/home/skoranda/CILogon2/comanage-registry-ansible/aws_ec2.yml']
DEFAULT_TIMEOUT(/home/skoranda/CILogon2/comanage-registry-ansible/ansible.cfg) = 60
DEFAULT_VAULT_PASSWORD_FILE(env: ANSIBLE_VAULT_PASSWORD_FILE) = /home/skoranda/.vault_pass.txt
INTERPRETER_PYTHON(/home/skoranda/CILogon2/comanage-registry-ansible/ansible.cfg) = auto_silent
OS / ENVIRONMENT

Debian 10.5

STEPS TO REPRODUCE

Run a playbook with the following task:

    - name: Provision DB 
      community.aws.rds_instance:
        availability_zone: us-east-2a
        engine: aurora
        engine_version: 5.6.10a
        allow_major_version_upgrade: no
        auto_minor_version_upgrade: yes
        db_cluster_identifier: cilogon-registry-cluster-01-dev
        db_instance_class: db.t3.small
        db_instance_identifier: cilogon-registry-dev
        db_parameter_group_name: cilogon-aurora-mysql-5-6-parameter-group-dev
        state: present
        region: us-east-2

The task shows

TASK [Provision DB] *********************************************************************
[WARNING]: Module did not set no_log for force_update_password
changed: [localhost]
EXPECTED RESULTS

No warning

ACTUAL RESULTS
[WARNING]: Module did not set no_log for force_update_password
@tremble tremble mentioned this issue Sep 24, 2020
Merged
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@goneri
ec2_vol: returns an up to date tag dict of the volume (ansible-collec…
bec6f91 
…tions#241)

This patch ensures a `ec2_vol` calls will return the up to date
tag structure.
Previously, the module was returning the origin tag dictionary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rds_instance: Set no_log=False on force_update_password tremble/community.aws
1 participant
@tremble