Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_eks_cluster does not support adding tags to cluster #1513

Open
1 task done
alanmcg opened this issue Sep 21, 2022 · 3 comments
Open
1 task done

aws_eks_cluster does not support adding tags to cluster #1513

alanmcg opened this issue Sep 21, 2022 · 3 comments
Labels
feature This issue/PR relates to a feature request waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@alanmcg
Copy link

alanmcg commented Sep 21, 2022 •
edited
Loading

Summary

All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console.

Issue Type

Feature Idea

Component Name

aws_eks_cluster

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @alanmcg
alanmcg




        changed the title
community.aws.aws_eks_cluster does not support adding tags to cluster

aws_eks_cluster does not support adding tags to cluster


      Sep 21, 2022

    

  








      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:

None


If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  needs_triage


  labels


      Sep 21, 2022

    

  








      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Hi @alanmcg, thank you for this feature idea. Would you be willing to work on this and open a pull request?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @alinabuzachis
alinabuzachis




            added
      

  waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked

    and removed
      

  needs_triage


  labels


      Nov 10, 2022

    

  








      

  
      



  

  @alanmcg





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  Author


  


  

    

      

      
            alanmcg
  

      

      

      commented


        Nov 11, 2022


      
    


  





      


        


  
    

      
          


Hi @alanmcg, thank you for this feature idea. Would you be willing to work on this and open a pull request?




I have asked a colleague who knows python to work on it :)

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @mohgho
mohgho



    mentioned this issue
    
      Nov 11, 2022
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Feb 3, 2023
    
    

      


  

    

      


  

      
        @mohgho
  





      

        
          eks_cluster: adding tags to eks cluster (#1591)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          3c1c903
        
      

    

  

    

      
eks_cluster: adding tags to eks cluster

SUMMARY
As described by issue #1513
All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_eks_cluster
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Amir <None>
Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  patchback bot

      pushed a commit
      that referenced
      this issue

    
      Feb 3, 2023
    
    

      


  

    

      


  

      
        @mohgho
      
        @patchback
  





      

        
          eks_cluster: adding tags to eks cluster (#1591)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          89d6d77
        
      

    

  

    

      
eks_cluster: adding tags to eks cluster

SUMMARY
As described by issue #1513
All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

aws_eks_cluster
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Amir <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 3c1c903)

    




    

  




  

  

    
  


  

      

    @patchback
patchback
bot


    mentioned this issue
    
      Feb 3, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Feb 3, 2023
    
    

      


  

    

      


  

      
        @patchback
  





      

        
          eks_cluster: adding tags to eks cluster (#1591) (#1699)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          27b849d
        
      

    

  

    

      
[PR #1591/3c1c903a backport][stable-5] eks_cluster: adding tags to eks cluster

This is a backport of PR #1591 as merged into main (3c1c903).
SUMMARY
As described by issue #1513
All the other community aws modules that I use support applying tags to the created resources (where such a feature is supported by aws). Using aws_eks_cluster it is not possible to add tags, although this appears to be a supported feature when viewing a cluster in the aws console.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_eks_cluster
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/community.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          Fstring cleanup (ansible-collections#1513)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          1ea813c
        
      

    

  

    

      
SUMMARY

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup

A combination of

    black --preview
    flynt
    some manual cleanup

ISSUE TYPE

    Feature Pull Request

COMPONENT NAME

plugins/
tests/unit/

ADDITIONAL INFORMATION

This PR is specifically targetting the RDS related modules.
There's still more to come...

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




              
No branches or pull requests







    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @alanmcg 
        
          @alinabuzachis 
        
          @ansibullbot