elb_application_ld modify rule: http-header not working

[DylanABacon]

SUMMARY

When using the "elb_application_lb" module to create/modify rules for a listener, the modify action for a http-header condition type does not work. If the rule is not already created, the module creates the rule correctly, but when it is already created, it returns an error: KeyError: 'Values'.
I am able to modify this rule with the aws cli.

ISSUE TYPE

• Bug Report

COMPONENT NAME

elb_application_lb for aws

ANSIBLE VERSION

ansible 2.9.6
  config file = None
  configured module search path = ['/home/dylan/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/dylan/.devops_envs/devops_smc/lib/python3.6/site-packages/ansible
  executable location = /home/dylan/.devops_envs/devops_smc/bin/ansible
  python version = 3.6.9 (default, Apr 18 2020, 01:56:04) [GCC 8.4.0]

CONFIGURATION

OS / ENVIRONMENT

Ubuntu 18

STEPS TO REPRODUCE

Create a playbook to create/modify the rule. On the first run it should successfully create the rule. On the second run, it returns an error.

name: create Load Balancer
  elb_application_lb:
    state: present
    name: "{{ load_balancer_name }}"
    security_groups: "{{ elb_security_group_name }}"
    subnets: "{{ vpc_subnet_list }}"
    listeners:
    - Protocol: HTTPS
      Port: 443
      SslPolicy: ELBSecurityPolicy-2016-08
      Certificates:
      - CertificateArn: "{{ https_certificate_arn }}"
      DefaultActions:
      - Type: fixed-response
        FixedResponseConfig:
          ContentType: text/plain
          StatusCode: "503"
      Rules:
      - Conditions:
          - Field: http-header
            HttpHeaderConfig:
              HttpHeaderName: 'User-Agent'
              Values: '*Trident/7:0*rv:11*'
        Priority: '1'
        Actions:
          - Type: fixed-response
            FixedResponseConfig:
              StatusCode: "200"
              ContentType: "text/html"
              MessageBody: "<b>Hello World!</b>"
  register:  create_lb_result

EXPECTED RESULTS

I expect the http-header rule to be updated if it is changed.

ACTUAL RESULTS

An error is returned: KeyError: 'Values'

I am able to modify te rule with the aws cli command:

aws elbv2 modify-rule   --actions Type="fixed-response",FixedResponseConfig='{MessageBody="<b>Hello World!</b>",ContentType="text/html",StatusCode="200"}'  --conditions Field=http-header,HttpHeaderConfig='{HttpHeaderName='User-Agent',Values='*Trident/7.0*rv:11*'}' --rule-arn arn:myarn

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: 'Values'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "rc": 1
}

MSG:

MODULE FAILURE
See stdout/stderr for the exact error


MODULE_STDERR:

Traceback (most recent call last):
  File "<stdin>", line 102, in <module>
  File "<stdin>", line 94, in _ansiballz_main
  File "<stdin>", line 40, in invoke_module
  File "/usr/lib/python3.6/runpy.py", line 205, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/modules/cloud/amazon/elb_application_lb.py", line 612, in <module>
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/modules/cloud/amazon/elb_application_lb.py", line 606, in main
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/modules/cloud/amazon/elb_application_lb.py", line 488, in create_or_update_elb
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/module_utils/aws/elbv2.py", line 809, in compare_rules
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/module_utils/aws/elbv2.py", line 784, in _compare_rule
  File "/tmp/ansible_elb_application_lb_payload_8gfeee49/ansible_elb_application_lb_payload.zip/ansible/module_utils/aws/elbv2.py", line 720, in _compare_condition
KeyError: 'Values'

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[jatorcasso]

Has this issue been resolved?

[markuman]

Has this issue been resolved?

Well spottet. I guess it is included since 1.4.0