Fix false positive no_log warning in iam module. (#202)

ansible-collections · Aug 26, 2020 · f5eb2c7 · f5eb2c7
1 parent 2d16b54
commit f5eb2c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/fragments/iam_no_log.yml b/changelogs/fragments/iam_no_log.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - iam - Fix false positive warning regarding use of ``no_log`` on ``update_password``
diff --git a/plugins/modules/iam.py b/plugins/modules/iam.py
@@ -622,7 +622,8 @@ def main():
         groups=dict(type='list', default=None, required=False, elements='str'),
         state=dict(required=True, choices=['present', 'absent', 'update']),
         password=dict(default=None, required=False, no_log=True),
-        update_password=dict(default='always', required=False, choices=['always', 'on_create']),
+        # setting no_log=False on update_password avoids a false positive warning about not setting no_log
+        update_password=dict(default='always', required=False, choices=['always', 'on_create'], no_log=False),
         access_key_state=dict(default=None, required=False, choices=[
             'active', 'inactive', 'create', 'remove',
             'Active', 'Inactive', 'Create', 'Remove']),