Skip to content

Commit

Permalink
elb_network_lb: Update tests to use valid cert (#2142)
Browse files Browse the repository at this point in the history
SUMMARY

The tests for network load balancers use an invalid cert:

      community.aws/tests/integration/targets/elb_network_lb/tasks/generate-certs.yml

         Line 7
      in
      d79e817

           size: 4096

.
As per AWS documentation Network load balancers only support RSA certs with up to 3072 bit keys.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

elb_network_lb
ADDITIONAL INFORMATION

https://docs.aws.amazon.com/elasticloadbalancing/latest/network/create-tls-listener.html#tls-listener-certificates
Supported key algorithms
RSA 1024-bit
RSA 2048-bit
RSA 3072-bit
ECDSA 256-bit
ECDSA 384-bit
ECDSA 521-bit

related to mattclay/aws-terminator#309

Reviewed-by: Mark Chappell
(cherry picked from commit f2f6284)
  • Loading branch information
mandar242 authored and patchback[bot] committed Sep 10, 2024
1 parent 4ccc0bd commit a90e5dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
trivial:
- elb_network_lb - Update tests to use valid cert RSA 3072-bit instead of 4096 (https://github.com/ansible-collections/community.aws/pull/2142).
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- name: 'Generate SSL Keys'
community.crypto.openssl_privatekey:
path: '{{ remote_tmp_dir }}/{{ item }}-key.pem'
size: 4096
size: 3072
loop:
- 'ca'
- 'cert1'
Expand Down

0 comments on commit a90e5dc

Please sign in to comment.