Parsing BGP neighbor passwords definitions and VRF bgp send-community no longer errors #482

jakegroves · 2023-11-08T23:04:08Z

SUMMARY

Parsing BGP neighbor passwords will not error on the type. As nolog only enabled for password and not the type
Parsing BGP neighbor in VRFs no longer errors when send-community is set without any attributes

Fixes #467

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

eos_bgp_global

ADDITIONAL INFORMATION

Example playbook

- hosts: all
  connection: network_cli
  gather_facts: no

  tasks:
    - name: Gather configuration
      arista.eos.eos_facts:
        gather_subset:
          - config

    - name: Gather BGP Info
      arista.eos.eos_bgp_global:
        state: gathered
        running_config: "{{ ansible_net_config }}"
      register: eos_bgp

    - name: Render BGP info
      arista.eos.eos_bgp_global:
        state: rendered
        config: "{{ eos_bgp.gathered }}"
      register: eos_bgp_rendered

Error with send community for vrf bgp neighbor:

TASK [Render BGP info] ******************************************************************************************************************************************************************************************************************************
fatal: [router-02.domain]: FAILED! => {
    "changed": false
}

MSG:

Unsupported parameters for (basic.py) module: config.vrfs.neighbor.send_community.set. Supported parameters include: state, config, running_config.

PLAY RECAP ******************************************************************************************************************************************************************************************************************************************
router-02.domain : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

Error with encryption password parsing on type

TASK [Render BGP info] ******************************************************************************************************************************************************************************************************************************
fatal: [router-02.domain]: FAILED! => {
    "changed": false
}

MSG:

argument 'type' is of type <class 'ansible.utils.unsafe_proxy.AnsibleUnsafeText'> found in 'config -> vrfs -> neighbor -> encryption_password'. and we were unable to convert to int: <class 'ansible.utils.unsafe_proxy.AnsibleUnsafeText'> cannot be converted to an int

PLAY RECAP ******************************************************************************************************************************************************************************************************************************************
router-02.domain : ok=2    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

After fixes:

PLAY [all] ******************************************************************************************************************************************************************************************************************************************

TASK [Gather configuration] *************************************************************************************************************************************************************************************************************************
[WARNING]: ansible-pylibssh not installed, falling back to paramiko
ok: [router-02.domain]

TASK [Gather BGP Info] ******************************************************************************************************************************************************************************************************************************
[WARNING]: Both option neighbor_address and its alias peer are set.
ok: [router-02.domain]

TASK [Render BGP info] ******************************************************************************************************************************************************************************************************************************
ok: [router-02.domain]

TASK [foobar] ***************************************************************************************************************************************************************************************************************************************
ok: [router-02.domain] => {}

MSG:

{'as_number': '65000', 'vrfs': [{'vrf': 'clean', 'router_id': '10.0.0.19', 'neighbor': [{'neighbor_address': '10.0.0.18', 'remote_as': '65000', 'next_hop_self': True, 'description': 'router-01', 'route_map': {'name': 'Outbound', 'direction': 'out'}}]}, {'vrf': 'dirty', 'neighbor': [{'neighbor_address': '10.0.1.191', 'remote_as': '65000', 'bfd': 'enable', 'description': 'upstream-router02', 'route_map': {'name': 'Outbound', 'direction': 'out'}, 'encryption_password': {'type': 7, 'password': 'VALUE_SPECIFIED_IN_NO_LOG_PARAMETER'}, 'peer': '10.0.1.191', 'send_community': {'set': True}, 'maximum_received_routes': {'count': 0}}]}], 'distance': {'external': 20, 'internal': 200, 'local': 200}}

…nly enabled for password and not the type Parsing BGP neighbor in VRFs no longer errors when send-community is set without any attributes

for more information, see https://pre-commit.ci

codecov · 2023-11-08T23:06:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fc41fc) 82.75% compared to head (2fcc223) 82.75%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         153      153           
  Lines       11967    11967           
=======================================
  Hits         9903     9903           
  Misses       2064     2064

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

softwarefactory-project-zuul · 2023-11-09T00:04:30Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bcac1884b23748b585243958c0aafc40

Parsing BGP neighbor passwords will not error on the type. As nolog o…

72ba9f7

…nly enabled for password and not the type Parsing BGP neighbor in VRFs no longer errors when send-community is set without any attributes

jakegroves temporarily deployed to ack November 8, 2023 23:04 — with GitHub Actions Inactive

[pre-commit.ci] auto fixes from pre-commit.com hooks

2fcc223

for more information, see https://pre-commit.ci

pre-commit-ci bot temporarily deployed to ack November 8, 2023 23:04 Inactive

NilashishC requested a review from rohitthakur2590 November 17, 2023 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parsing BGP neighbor passwords definitions and VRF bgp send-community no longer errors #482

Parsing BGP neighbor passwords definitions and VRF bgp send-community no longer errors #482

jakegroves commented Nov 8, 2023

codecov bot commented Nov 8, 2023

softwarefactory-project-zuul bot commented Nov 9, 2023

Parsing BGP neighbor passwords definitions and VRF bgp send-community no longer errors #482

Are you sure you want to change the base?

Parsing BGP neighbor passwords definitions and VRF bgp send-community no longer errors #482

Conversation

jakegroves commented Nov 8, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

codecov bot commented Nov 8, 2023

Codecov Report

softwarefactory-project-zuul bot commented Nov 9, 2023