Update win_share to support cluster role shares #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
approved these changes
Nov 15, 2023
shahargolshani
pushed a commit
to shahargolshani/ansible.windows
that referenced
this pull request
Dec 2, 2024
shahargolshani
pushed a commit
to shahargolshani/ansible.windows
that referenced
this pull request
Dec 3, 2024
jborean93
added a commit
that referenced
this pull request
Dec 4, 2024
jborean93
added a commit
that referenced
this pull request
Dec 8, 2024
Yaish25491
pushed a commit
to Yaish25491/ansible.windows
that referenced
this pull request
Jan 2, 2025
Yaish25491
pushed a commit
to Yaish25491/ansible.windows
that referenced
this pull request
Jan 6, 2025
jborean93
added a commit
that referenced
this pull request
Jan 7, 2025
jborean93
added a commit
that referenced
this pull request
Jan 8, 2025
Yaish25491
pushed a commit
to Yaish25491/ansible.windows
that referenced
this pull request
Jan 9, 2025
shahargolshani
pushed a commit
to shahargolshani/ansible.windows
that referenced
this pull request
Jan 9, 2025
jborean93
added a commit
that referenced
this pull request
Jan 9, 2025
jborean93
added a commit
that referenced
this pull request
Jan 9, 2025
amitosw15
pushed a commit
to amitosw15/ansible.windows
that referenced
this pull request
Jan 12, 2025
amitosw15
pushed a commit
to amitosw15/ansible.windows
that referenced
this pull request
Jan 12, 2025
amitosw15
pushed a commit
to amitosw15/ansible.windows
that referenced
this pull request
Jan 13, 2025
amitosw15
pushed a commit
to amitosw15/ansible.windows
that referenced
this pull request
Jan 13, 2025
amitosw15
pushed a commit
to amitosw15/ansible.windows
that referenced
this pull request
Jan 15, 2025
jborean93
added a commit
that referenced
this pull request
Jan 17, 2025
* New module: win_listen_ports_facts (#379) * Initial implementation of win_listen_ports_facts * Docs updated. * Changes based on suggestions * New approach to the processes obtaining method * Replace WMI with CIM * Avoid Bound state in tests, as it is PS4.0+. * Upgrade ansible-lint and fix problems (#565) * complete module migration Signed-off-by: Amit Weinstock <[email protected]> * add verification test and change param name Signed-off-by: Amit Weinstock <[email protected]> --------- Signed-off-by: Amit Weinstock <[email protected]> Co-authored-by: David Nieto Sanz <[email protected]> Co-authored-by: Jordan Borean <[email protected]>
jborean93
added a commit
that referenced
this pull request
Jan 19, 2025
* Initial commit * Fix tests - ci_complete ci_coverage * Fix up docs after migration (#95) * Fix up docs after migration * Fix up sanity errors * fix up sanity ignores (#97) * fix up sanity ignores * Bump ansible-windows dep * Fix bad change for win_region * Rebalance the test targets (#128) * Rebalance the test targets * Make sure IIS test removes the service so our httptester works * Fix new devel sanity check (#215) * Fix devel sanity checks - ci_complete (#331) * Upgrade ansible-lint and fix problems (#565) * complete module migration Signed-off-by: Amit Weinstock <[email protected]> * change module source in docs Signed-off-by: Amit Weinstock <[email protected]> * migrate module --------- Signed-off-by: Amit Weinstock <[email protected]> Co-authored-by: Jordan Borean <[email protected]>
jborean93
added a commit
that referenced
this pull request
Jan 19, 2025
* Initial commit * Fix tests - ci_complete ci_coverage * Fix up docs after migration (#95) * Fix up docs after migration * Fix up sanity errors * fix up sanity ignores (#97) * fix up sanity ignores * Bump ansible-windows dep * Fix bad change for win_region * Rebalance the test targets (#128) * Rebalance the test targets * Make sure IIS test removes the service so our httptester works * Fix new devel sanity check (#215) * Fix devel sanity checks - ci_complete (#331) * Remove some code that is incompatible with dotnet 5+ (#529) * Upgrade ansible-lint and fix problems (#565) * complete module migration Signed-off-by: Amit Weinstock <[email protected]> * add fully qualified modules names to docs --------- Signed-off-by: Amit Weinstock <[email protected]> Co-authored-by: Jordan Borean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This branch adds the
scope_nameparam to the win_share module, allowing users to scope their file share to a Windows Server failover cluster role.Tests have been optimized/updated accordingly - cluster specific tests have been created but are off by default. These tests require a properly configured failover cluster with one cluster role and one shared disk. I am running theses tests successfully in our internal CI pipeline.
ISSUE TYPE
COMPONENT NAME
win_share
ADDITIONAL INFORMATION
Internal VMW Reference AWSA-32719