Win group membership fix check mode final

[nagten]

SUMMARY

Fixes #532

Using check_mode on ansible.windows.win_group_membership module does not return accurate result values.

The win_group_membership module has 4 return values, but the added/removed and members value do not represent accurate results when using pure mode.

I we populate the $result variable with added and removed values we'll get accurate results in check_mode, currently the $result variable is only updated when we don't run in check_mode
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.windows.win_group_membership
ADDITIONAL INFORMATION

Before:

ok: [testserver.fabrikam.com] => {
"varlocalmembership": {
"added": [],
"changed": true,
"failed": false,
"members": [
"TESTSERVER\Administrator",
"FABRIKAM\Domain Admins",
"TESTSERVER\LocalAccount",
"FABRIKAM\G-WSOSADMIN",
"FABRIKAM\G-TESTSERVER-ADMIN",
"FABRIKAM\G-SQLDB-A"
],
"name": "Administrators",
"removed": []
}
}

After:

ok: [testserver.fabrikam.com] => {
"varlocalmembership": {
"added": [
"FABRIKAM\G-SQLDB-P"
],
"changed": true,
"failed": false,
"members": [
"TESTSERVER\Administrator",
"FABRIKAM\Domain Admins",
"TESTSERVER\LocalAccount",
"FABRIKAM\G-WSOSADMIN",
"FABRIKAM\G-TESTSERVER-ADMIN"
],
"name": "Administrators",
"removed": [
"FABRIKAM\G-SQLDB-A"
]
}
}

[nagten]

Created a new pull request the old one contained to many small updates, pure testing threw me off because the users weren't correctly setup (because check_mode need to be disable when settting up test users)

[jborean93]

Thanks for persisting with this.